Title: [89604] trunk/Source/WebCore
- Revision
- 89604
- Author
- t...@chromium.org
- Date
- 2011-06-23 12:53:41 -0700 (Thu, 23 Jun 2011)
Log Message
2011-06-23 Tony Chang <t...@chromium.org>
Reviewed by Andreas Kling.
Pass Strings as const references in NetworkResourcesData.h
https://bugs.webkit.org/show_bug.cgi?id=63271
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::setFrameId):
(WebCore::NetworkResourcesData::ResourceData::setUrl):
(WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89603 => 89604)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 19:52:31 UTC (rev 89603)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 19:53:41 UTC (rev 89604)
@@ -1,3 +1,15 @@
+2011-06-23 Tony Chang <t...@chromium.org>
+
+ Reviewed by Andreas Kling.
+
+ Pass Strings as const references in NetworkResourcesData.h
+ https://bugs.webkit.org/show_bug.cgi?id=63271
+
+ * inspector/NetworkResourcesData.h:
+ (WebCore::NetworkResourcesData::ResourceData::setFrameId):
+ (WebCore::NetworkResourcesData::ResourceData::setUrl):
+ (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
+
2011-06-23 Jay Civelli <jcive...@chromium.org>
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/inspector/NetworkResourcesData.h (89603 => 89604)
--- trunk/Source/WebCore/inspector/NetworkResourcesData.h 2011-06-23 19:52:31 UTC (rev 89603)
+++ trunk/Source/WebCore/inspector/NetworkResourcesData.h 2011-06-23 19:53:41 UTC (rev 89604)
@@ -56,10 +56,10 @@
String loaderId() const { return m_loaderId; }
String frameId() const { return m_frameId; }
- void setFrameId(String frameId) { m_frameId = frameId; }
+ void setFrameId(const String& frameId) { m_frameId = frameId; }
String url() const { return m_url; }
- void setUrl(String url) { m_url = url; }
+ void setUrl(const String& url) { m_url = url; }
bool hasContent() const { return m_hasContent; }
String content();
@@ -76,7 +76,7 @@
void setBuffer(PassRefPtr<SharedBuffer> buffer) { m_buffer = buffer; }
String textEncodingName() const { return m_textEncodingName; }
- void setTextEncodingName(String textEncodingName) { m_textEncodingName = textEncodingName; }
+ void setTextEncodingName(const String& textEncodingName) { m_textEncodingName = textEncodingName; }
CachedResource* cachedResource() const { return m_cachedResource.get(); }
void setCachedResource(CachedResource* cachedResource) { m_cachedResource = cachedResource; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
