Title: [89065] trunk/Source
- Revision
- 89065
- Author
- [email protected]
- Date
- 2011-06-16 14:18:35 -0700 (Thu, 16 Jun 2011)
Log Message
2011-06-16 Sailesh Agrawal <[email protected]>
Reviewed by Mihai Parparita.
[Chromium] Overlay scrollbars leave glitches on web content
https://bugs.webkit.org/show_bug.cgi?id=62383
Enable overlay scrollbars on Chromium Mac.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(preferredScrollerStyle):
2011-06-16 Sailesh Agrawal <[email protected]>
Reviewed by Mihai Parparita.
[Chromium] Overlay scrollbars leave glitches on web content
https://bugs.webkit.org/show_bug.cgi?id=62383
Fix glitches when scrolling with overlay scrollbars. The problem was that the render widget was copying the scrollbars when scrolling. Fix was to intersect the clip rect with the scroll rect. This is the same thing that Safari does (see WebChromeClient::scroll).
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scroll):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89064 => 89065)
--- trunk/Source/WebCore/ChangeLog 2011-06-16 21:17:49 UTC (rev 89064)
+++ trunk/Source/WebCore/ChangeLog 2011-06-16 21:18:35 UTC (rev 89065)
@@ -1,3 +1,15 @@
+2011-06-16 Sailesh Agrawal <[email protected]>
+
+ Reviewed by Mihai Parparita.
+
+ [Chromium] Overlay scrollbars leave glitches on web content
+ https://bugs.webkit.org/show_bug.cgi?id=62383
+
+ Enable overlay scrollbars on Chromium Mac.
+
+ * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+ (preferredScrollerStyle):
+
2011-06-16 una sabovic <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (89064 => 89065)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-06-16 21:17:49 UTC (rev 89064)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-06-16 21:18:35 UTC (rev 89065)
@@ -124,11 +124,6 @@
static NSScrollerStyle preferredScrollerStyle()
{
- // TODO(sail): Disable overlay scrollbars for now until the following issues are fixed:
- // #1: Invalidation issues causes the scrollbar to leave trailing artifacts.
- // #2: Find tick marks need to be drawn on the scrollbar track.
- return NSScrollerStyleLegacy;
-
if ([NSScroller respondsToSelector:@selector(preferredScrollerStyle)])
return [NSScroller preferredScrollerStyle];
return NSScrollerStyleLegacy;
Modified: trunk/Source/WebKit/chromium/ChangeLog (89064 => 89065)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-16 21:17:49 UTC (rev 89064)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-16 21:18:35 UTC (rev 89065)
@@ -1,3 +1,15 @@
+2011-06-16 Sailesh Agrawal <[email protected]>
+
+ Reviewed by Mihai Parparita.
+
+ [Chromium] Overlay scrollbars leave glitches on web content
+ https://bugs.webkit.org/show_bug.cgi?id=62383
+
+ Fix glitches when scrolling with overlay scrollbars. The problem was that the render widget was copying the scrollbars when scrolling. Fix was to intersect the clip rect with the scroll rect. This is the same thing that Safari does (see WebChromeClient::scroll).
+
+ * src/ChromeClientImpl.cpp:
+ (WebKit::ChromeClientImpl::scroll):
+
2011-06-16 Ryosuke Niwa <[email protected]>
Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp (89064 => 89065)
--- trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp 2011-06-16 21:17:49 UTC (rev 89064)
+++ trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp 2011-06-16 21:18:35 UTC (rev 89065)
@@ -555,7 +555,7 @@
if (m_webView->client()) {
int dx = scrollDelta.width();
int dy = scrollDelta.height();
- m_webView->client()->didScrollRect(dx, dy, clipRect);
+ m_webView->client()->didScrollRect(dx, dy, intersection(scrollRect, clipRect));
}
#if USE(ACCELERATED_COMPOSITING)
} else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
