Title: [88507] trunk
Revision
88507
Author
[email protected]
Date
2011-06-09 17:30:25 -0700 (Thu, 09 Jun 2011)

Log Message

2011-06-09  James Robinson  <[email protected]>

        [chromium] Mark the fullscreen directory as skipped
        https://bugs.webkit.org/show_bug.cgi?id=62397

        * platform/chromium/test_expectations.txt:
2011-06-09  James Robinson  <[email protected]>

        Reviewed by Eric Seidel.

        [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
        https://bugs.webkit.org/show_bug.cgi?id=62397

        Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
        even when the runtime setting was disabled.

        * features.gypi:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (88506 => 88507)


--- trunk/LayoutTests/ChangeLog	2011-06-10 00:30:21 UTC (rev 88506)
+++ trunk/LayoutTests/ChangeLog	2011-06-10 00:30:25 UTC (rev 88507)
@@ -1,3 +1,10 @@
+2011-06-09  James Robinson  <[email protected]>
+
+        [chromium] Mark the fullscreen directory as skipped
+        https://bugs.webkit.org/show_bug.cgi?id=62397
+
+        * platform/chromium/test_expectations.txt:
+
 2011-06-09  Gavin Barraclough  <[email protected]>
 
         Reviewed by Oliver Hunt.

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88506 => 88507)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-10 00:30:21 UTC (rev 88506)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-10 00:30:25 UTC (rev 88507)
@@ -831,6 +831,9 @@
 BUGCR16735 SKIP : media/media-fullscreen-inline.html = TIMEOUT
 BUGCR16735 SKIP : media/media-fullscreen-not-in-document.html = TIMEOUT
 
+// We haven't implemented the WebKit fullscreen API yet
+BUGCR73923 SKIP : fullscreen = TIMEOUT FAIL
+
 // We haven't implemented the WebKit captioning extension.
 // UNIMPLEMENTED
 BUGCR28301 SKIP : media/media-captions.html = TIMEOUT
@@ -3598,7 +3601,6 @@
 
 BUGDPRANKE WIN : http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain.html = TIMEOUT PASS
 BUGDPRANKE MAC LINUX DEBUG : fast/css/only-of-type-pseudo-class.html = TEXT PASS
-BUGDPRANKE LINUX DEBUG : fullscreen/full-screen-iframe-allowed.html = TEXT PASS
 BUGDPRANKE LINUX DEBUG : jquery/deferred.html = TEXT PASS
 
 // Introduced in r84443
@@ -3764,9 +3766,6 @@
 // Since http://trac.webkit.org/changeset/85788
 BUGWK60237 DEBUG : svg/text/text-block-child-crash.xhtml = PASS CRASH
 
-// The test is added at r85811.
-BUGWK60243 : fullscreen/full-screen-stacking-context.html = IMAGE
-
 BUGWK60252 MAC GPU : animations/3d/matrix-transform-type-animation.html = IMAGE
 BUGWK60252 MAC GPU : animations/3d/state-at-end-event-transform.html = IMAGE
 

Modified: trunk/Source/WebKit/chromium/ChangeLog (88506 => 88507)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-10 00:30:21 UTC (rev 88506)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-10 00:30:25 UTC (rev 88507)
@@ -1,3 +1,15 @@
+2011-06-09  James Robinson  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=62397
+
+        Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
+        even when the runtime setting was disabled.
+
+        * features.gypi:
+
 2011-06-09  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r88486.

Modified: trunk/Source/WebKit/chromium/features.gypi (88506 => 88507)


--- trunk/Source/WebKit/chromium/features.gypi	2011-06-10 00:30:21 UTC (rev 88506)
+++ trunk/Source/WebKit/chromium/features.gypi	2011-06-10 00:30:25 UTC (rev 88507)
@@ -61,7 +61,6 @@
         'ENABLE_JAVASCRIPT_I18N_API=1',
         'ENABLE_FILE_SYSTEM=1',
         'ENABLE_FILTERS=1',
-        'ENABLE_FULLSCREEN_API=1',
         'ENABLE_GEOLOCATION=1',
         'ENABLE_GESTURE_RECOGNIZER=1',
         'ENABLE_ICONDATABASE=0',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to