I did notice after looking at the change in the repository logs. I lthought
about why you would concantinate the space and then it clicked. Dock that one
for another intelligence point.
Thanks,
jb
----- Original message -----
> I have to say, good catch, but bad fix from i18n point of view. Your
> "insert new " (one blank space at the end) string makes all current
> language translations for "insert new" become broken. As a general
> rule, please don't insert leading or trailing or any unnecessary space
> inside a T("blah") content.
>
> Didn't you see the string concatenate code in the same line of source?
> The correct fix would be concatenate a space outside of the T("...").
> Like this:
> A(str(T('insert new'))+' '+table, ...
>
> Regards,
> Iceberg
>
> On Aug 14, 12:52 am, Jason Brower <encomp...@gmail.com> wrote:
> > It was 'insert new' and now it's 'insert new '
> > Small one, but important for that polished look.
> > BR,
> > Jason Brower
> >
> >
> >
> > On Fri, 2010-08-13 at 09:39 -0700, mdipierro wrote:
> > > Sorry. I do not see the difference
> >
> > > On Aug 13, 11:26 am, Jason Brower <encomp...@gmail.com> wrote:
> > > > Oh yeah! Haven't a clue how to do a patch file, but here is the
> > > > change...
> > > > Line 33 in the appadmin.html
> > > > [ {{=A(str(T('insert
> > > > new'))+''+table,_href=URL(r=request,f='insert',args=[db,table]))}}
> > > > ] should be:
> > > > [ {{=A(str(T('insert new
> > > > '))+''+table,_href=URL(r=request,f='insert',args=[db,table]))}} ]
> > > > Just a small formating issue. (: But it feels good to actual give
> > > > SOMETHING.
> > > > BR,
> > > > Jason Brower
