I think we should check if the file exists before try to delete it.

or move the unlik() function to a new "try-except" block, something like:

if welcome.w2p is correctly created:

    try:

        os.unlink('NEWINSTALL')

    except FileNotFoundError:

        nothing to do

    except:

        error removing 'NEWINSTALL' file


Greetings.


El 23/04/18 a las 13:33, Richard Vézina escribió:
Actually it already inside a try... And it only logging an error... Should this be an error or a warning?? I guess this is done for the appadmin to allow it to create new app as it base on welcome... The welcome template is provision at first web2py run once install and derived from the welcome app...

I guess it wouldn't be a good solution to track this NEWINSTALL file in the repo, as it could trigger some other issue... But at the same time, if you manage your web2py install with git, it might just make sens that whenever you update your local repo, that this file get recreated and the template being updated??

Richard

On Mon, Apr 23, 2018 at 1:28 PM, Richard Vézina <[email protected] <mailto:[email protected]>> wrote:

    I guess we could had a simple "try" there...

    Richard

    On Mon, Apr 23, 2018 at 1:26 PM, Richard Vézina
    <[email protected] <mailto:[email protected]>>
    wrote:

        Yeah this file is not there when we clone web2py... But I just
        check and it's there when you download web2py build from
        web2py.com...

        What's weird is that I didn't have the issue...

        Richard

        On Mon, Apr 23, 2018 at 12:39 PM, Carlos Cesar Caballero Díaz
        <[email protected]
        <mailto:[email protected]>> wrote:

            Ok, I have found the issue:

            ------------------------------------------------------------
            Traceback (most recent call last):
              File
            "/home/carlos.caballero/test/w2ptest/gluon/fileutils.py",
            line 270, in create_welcome_w2p
                os.unlink('NEWINSTALL')
            FileNotFoundError: [Errno 2] No such file or directory:
            'NEWINSTALL'
            ------------------------------------------------------------

            El 23/04/18 a las 11:48, Richard Vézina escribió:
            In gluon/fileutil.py

            Richard

            On Mon, Apr 23, 2018 at 11:47 AM, Richard Vézina
            <[email protected]
            <mailto:[email protected]>> wrote:

                The python3 welcome.w2p creation issue??

                I think it a dependency issue that might be
                obufuscated by _compat.py

                You can try to replace this line :

                w2p_pack('welcome.w2p', 'applications/welcome')

                By

                w2p_pack('welcome.w2p', 'applications', 'welcome')

                And report here if it help...

                Richard

                On Mon, Apr 23, 2018 at 11:42 AM, Carlos Cesar
                Caballero Díaz <[email protected]
                <mailto:[email protected]>> wrote:

                    I have the same issue, using the current master
                    branch in Ubuntu.

                    Greetings.


                    El 21/04/18 a las 08:21, Richard Vézina escribió:
                    Actually I can't reproduced... It could it be a
                    permission error??

                    Try to clone it fresh some where you have full
                    access with this command :

                    git clone --recursive
                    https://github.com/web2py/web2py.git
                    <https://github.com/web2py/web2py.git>

                    Then

                    cd web2py
                    python3 web2py.py

                    Enter password


                    Richard

                    On Sat, Apr 21, 2018 at 8:01 AM, Richard Vézina
                    <[email protected]
                    <mailto:[email protected]>> wrote:

                        Can you open an issue?

                        I think it related to this :
                        
https://github.com/web2py/web2py/blob/fb4c114d85494ad6d79d69539adaae103d76e5ce/gluon/fileutils.py#L269
                        
<https://github.com/web2py/web2py/blob/fb4c114d85494ad6d79d69539adaae103d76e5ce/gluon/fileutils.py#L269>

                        Path string that has to be manipulated
                        differently in python 3

                        Explanation

                        https://www.scivision.co/python-idiomatic-pathlib-use/
                        <https://www.scivision.co/python-idiomatic-pathlib-use/>

                        On Fri, Apr 20, 2018 at 9:15 PM, lyn2py
                        <[email protected] <mailto:[email protected]>>
                        wrote:

                            I just git cloned the latest web2py and
                            started it up with *python3*
                            |
                            Version
                            2.16.1-stable+timestamp.2018.03.08.10.23.01
                            Database drivers available: sqlite3,
                            imaplib, pymysql, pyodbc
                            |

                            I got this error in console
                            |
                            ERROR:root:Newinstallation error:unable
                            to create welcome.w2p file
                            |

                            When I quit the python server and
                            restart with python2 or python3, the
                            error does not come up anymore.




                            On Tuesday, November 14, 2017 at 1:59:52
                            PM UTC+8, Massimo Di Pierro wrote:

                                web2py 2.16.1 is OUT

                                Lots of bugs fixes contributed by
                                the community. Thanks Leonel, Paolo,
                                Giovanni, and all those who contributed.

                                the most visible changes are:

                                - welcome now defaults to bootstrap 4
                                - lots of cleanup in the welcome app
                                and new examples in default.py
                                - simplified layout.html

                                Massimo



-- Resources:
                            - http://web2py.com
                            - http://web2py.com/book (Documentation)
                            - http://github.com/web2py/web2py
                            <http://github.com/web2py/web2py>
                            (Source code)
                            -
                            https://code.google.com/p/web2py/issues/list
                            <https://code.google.com/p/web2py/issues/list>
                            (Report Issues)
                            ---
                            You received this message because you
                            are subscribed to the Google Groups
                            "web2py-users" group.
                            To unsubscribe from this group and stop
                            receiving emails from it, send an email
                            to [email protected]
                            <mailto:[email protected]>.
                            For more options, visit
                            https://groups.google.com/d/optout
                            <https://groups.google.com/d/optout>.



-- Resources:
                    - http://web2py.com
                    - http://web2py.com/book (Documentation)
                    - http://github.com/web2py/web2py
                    <http://github.com/web2py/web2py> (Source code)
                    - https://code.google.com/p/web2py/issues/list
                    <https://code.google.com/p/web2py/issues/list>
                    (Report Issues)
                    ---
                    You received this message because you are
                    subscribed to the Google Groups "web2py-users"
                    group.
                    To unsubscribe from this group and stop
                    receiving emails from it, send an email to
                    [email protected]
                    <mailto:[email protected]>.
                    For more options, visit
                    https://groups.google.com/d/optout
                    <https://groups.google.com/d/optout>.

-- Resources:
                    - http://web2py.com
                    - http://web2py.com/book (Documentation)
                    - http://github.com/web2py/web2py
                    <http://github.com/web2py/web2py> (Source code)
                    - https://code.google.com/p/web2py/issues/list
                    <https://code.google.com/p/web2py/issues/list>
                    (Report Issues)
                    ---
                    You received this message because you are
                    subscribed to the Google Groups "web2py-users" group.
                    To unsubscribe from this group and stop receiving
                    emails from it, send an email to
                    [email protected]
                    <mailto:[email protected]>.
                    For more options, visit
                    https://groups.google.com/d/optout
                    <https://groups.google.com/d/optout>.



-- Resources:
            - http://web2py.com
            - http://web2py.com/book (Documentation)
            - http://github.com/web2py/web2py
            <http://github.com/web2py/web2py> (Source code)
            - https://code.google.com/p/web2py/issues/list
            <https://code.google.com/p/web2py/issues/list> (Report
            Issues)
            ---
            You received this message because you are subscribed to
            the Google Groups "web2py-users" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to
            [email protected]
            <mailto:[email protected]>.
            For more options, visit
            https://groups.google.com/d/optout
            <https://groups.google.com/d/optout>.

-- Resources:
            - http://web2py.com
            - http://web2py.com/book (Documentation)
            - http://github.com/web2py/web2py
            <http://github.com/web2py/web2py> (Source code)
            - https://code.google.com/p/web2py/issues/list
            <https://code.google.com/p/web2py/issues/list> (Report Issues)
            ---
            You received this message because you are subscribed to
            the Google Groups "web2py-users" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to
            [email protected]
            <mailto:[email protected]>.
            For more options, visit https://groups.google.com/d/optout
            <https://groups.google.com/d/optout>.




--
Resources:
- http://web2py.com
- http://web2py.com/book (Documentation)
- http://github.com/web2py/web2py (Source code)
- https://code.google.com/p/web2py/issues/list (Report Issues)
---
You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected] <mailto:[email protected]>.
For more options, visit https://groups.google.com/d/optout.

--
Resources:
- http://web2py.com
- http://web2py.com/book (Documentation)
- http://github.com/web2py/web2py (Source code)
- https://code.google.com/p/web2py/issues/list (Report Issues)
--- You received this message because you are subscribed to the Google Groups "web2py-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to