On Wednesday, August 16, 2017 at 6:30:52 AM UTC-7, Richard wrote: > > Now you make a PR (Pull Request)... But I think you commit againts > master/trunk... You should have create a branch (git checkout -b > branch/name-that-describe-the-nature-of-the-change) > > Richard -- I've done PRs against the book before. I got confused about what master was being pointed at, so the branch shows in MY repository instead of the official one.
/dps > Always > git checkout master, make sure master is up to date then create a branch > from master... > > > *Step by step commands :* > > git fetch upstream > git merge upstream/master > git push origin master (update you github clone repo) > *Then* > git checkout -b branch/name-that-describe-the-nature-of-the-change > *Then make your change (don't edit to much file in the same commit, > preferably one file one change except of you change need modification to > many files at once)* > git commit -m "your commit message description that shouldn't exceed 50-70 > characters" > *Then * > git push origin branch/name-that-describe-the-nature-of-the-change > *Then you go over you github repo (clone) and you make a PR* > > *Before all this you need a local repository instance* > > *git clone git-repo-name > (https://help.github.com/articles/cloning-a-repository/ > <https://help.github.com/articles/cloning-a-repository/>)* > *Then* > *Configue origin and upstream : > https://help.github.com/articles/configuring-a-remote-for-a-fork/ > <https://help.github.com/articles/configuring-a-remote-for-a-fork/>* > > *Of course you need git install and up to date and you need to configure > it > : https://git-scm.com/book/fr/v1/Personnalisation-de-Git-Configuration-de-Git > <https://git-scm.com/book/fr/v1/Personnalisation-de-Git-Configuration-de-Git>* > *In linux you can simply edit .gitconfig and paste :* > [user] > name = YOUR NAME > email = your....@domain.com <javascript:> > > Happy hacking and contribution... > > Richard > > > > On Wed, Aug 16, 2017 at 5:03 AM, Dave S <snide...@gmail.com <javascript:>> > wrote: > >> >> >> On Wednesday, August 9, 2017 at 4:44:45 AM UTC-7, Leonel Câmara wrote: >>> >>> 5. the ANY_OF validator also needs to be documented >>> >> >> >> I've done pull requests for ASSIGNJS and ANY_OF, but they went to my fork >> :-( >> >> <URL:https://github.com/snidelytoo/web2py-book/pulls> >> >> The Windows GitHub Gooey-App doesn't seem interested in having me >> redirect them to the official tree. If they can be grabbed from my fork, >> or one of you can coach me in how to get them to the right place, then we >> may have something. >> >> /dps >> >> >> >> -- >> Resources: >> - http://web2py.com >> - http://web2py.com/book (Documentation) >> - http://github.com/web2py/web2py (Source code) >> - https://code.google.com/p/web2py/issues/list (Report Issues) >> --- >> You received this message because you are subscribed to the Google Groups >> "web2py-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to web2py+un...@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- Resources: - http://web2py.com - http://web2py.com/book (Documentation) - http://github.com/web2py/web2py (Source code) - https://code.google.com/p/web2py/issues/list (Report Issues) --- You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to web2py+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
