Hi Mariano,
The patches are for the pyfpdf web2py sample app, (I'm not seeing that in
the main pyfpdf src, but I might have missed it).
Yes, I seemed to need a few additional 'pass' statements to avoid the view
complaining. I may have been over zealous :-)
In terms of style, I was following
web2py/applications/welcome/views/generic.pdf, but yeah doing a {{=...}}
would be ok too (several of the other welcome app views are coded that way)!
Cheers
Mark
On Tuesday, November 11, 2014 1:30:44 PM UTC+13, Mariano Reingart wrote:
>
> Hello Mark:
>
> Thanks for the patch!
>
> This fix is for the wiki page or the code itself?
> Could you create a new issue in the project site?
>
> https://code.google.com/p/pyfpdf/issues/list
>
> Or do you want to edit the page directly (I can give you the needed
> permisions)
>
> Even better, for the soure code, you make a Pull Request to GitHub mirror,
> that would be faster:
>
> https://github.com/reingart/pyfpdf
>
> BTW, why did you add some pass in the patch? are them to close the block?
> Also, the return replaced by =, I guess that it works, but maybe it is
> better to make a separate block {{=}}
> Sorry, I didn't have time to fully reproduce the issue.
> If you can comment the code and assure it is working, that would be great!
>
> Feel free to contact me, I'm one of the current maintainers of pyfpdf,
>
> Best regards,
>
> Mariano Reingart
> http://www.sistemasagiles.com.ar
> http://reingart.blogspot.com
>
> On Mon, Nov 10, 2014 at 8:38 PM, Mark Kirkwood <mark.k...@gmail.com
> <javascript:>> wrote:
>
>> Ok so the above plan works fine*. *In the interest of completeness, the
>> original demo code can be made to work sensibly on modern web2py (2.9.11).
>> So you can remove the code in the controller and (essentially) paste it
>> into a view. But a few corrections are needed - the major ones being adding
>> =XML() around the pdf.output call and just using {{ instead of {{{ . A diff
>> is attached.
>>
>> --
>> Resources:
>> - http://web2py.com
>> - http://web2py.com/book (Documentation)
>> - http://github.com/web2py/web2py (Source code)
>> - https://code.google.com/p/web2py/issues/list (Report Issues)
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "web2py-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to web2py+un...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
--
Resources:
- http://web2py.com
- http://web2py.com/book (Documentation)
- http://github.com/web2py/web2py (Source code)
- https://code.google.com/p/web2py/issues/list (Report Issues)
---
You received this message because you are subscribed to the Google Groups
"web2py-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to web2py+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
