> > More technically, one of the biggest code smells for me, is when you need > to remember to change things in more than one place when adding a feature. > Someone is bound to forget it. This feature may also hide a bug where a > user forgets to add a query for one of the tables but still gets the > results so everything appears to be fine. >
I'm not sure exactly what you mean by needing to change things in more than one place in this context, but regarding the common_filters feature, I think the code could be easily be changed to make it work whether or not a query is specified. In that case, the user wouldn't have to worry about forgetting anything -- the common_filter would just always work. Anthony -- Resources: - http://web2py.com - http://web2py.com/book (Documentation) - http://github.com/web2py/web2py (Source code) - https://code.google.com/p/web2py/issues/list (Report Issues) --- You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to web2py+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
