Always. :-) Rules are simple. I always take a patch if: 1) fixes a security issue OR 2) does not break backward compatibility AND 3) makes web2py faster OR 4) add a new functionality without making previous behavior slower
On Wednesday, 15 January 2014 00:41:54 UTC-6, James Q wrote: > > Massimo: Would you consider taking a patch / pull request for a new script? > > -- James > > On Thursday, January 9, 2014 9:16:02 AM UTC-5, Massimo Di Pierro wrote: >> >> The problem is that it would not work. you can have exceptions at two >> levels: web2py apps, web2py itself. In other frameworks these two levels >> are mixed up so sentry will catch either exceptions. In web2py the two >> levels are well separated and web2py catches app exceptions before they >> propagate up and sentry would not catch them. sentry would only catch >> exceptions in web2py itself and that is pretty much useless. >> >> You can think about it in another way, web2py already has a mechanism to >> catch exceptions and log them. and you cannot do: >> >> try: >> try: >> do something >> exceptiion: >> web2py ticket system >> except: >> sentry logging system >> >> and expect the second except to catch anything. Look instead into >> scritps/tickets2db.py and scripts/tickets2email.py and modify them to do >> what you need to do. >> >> >> On Wednesday, 8 January 2014 23:27:46 UTC-6, James Q wrote: >>> >>> Interesting. I have never written wsgi middleware, any pointers on that? >>> As middleware, I would still need to have an understanding of how to detect >>> if an exception has been logged in the request, no? >>> >>> Thanks! >>> >>> -- J >>> >>> On Tuesday, January 7, 2014 8:24:14 PM UTC-5, Derek wrote: >>>> >>>> I haven't, but I've done something similar with a different piece of >>>> software. You'd usually just use it as a wsgi middleware around your app. >>>> So you'd need to run web2py as wsgi and wrap it with Sentry. >>>> >>>> On Monday, January 6, 2014 8:14:46 PM UTC-7, James Q wrote: >>>>> >>>>> Has anyone ever integrated web2py an Sentry ( >>>>> https://github.com/getsentry/sentry)? I would like it if all web2py >>>>> generated exceptions generate a ticket like usual, but also generates an >>>>> event to a sentry server. Has anyone ever done this? If not, could anyone >>>>> point to where I would need to patch web2py or how best this integration >>>>> would work? >>>>> >>>>> Thanks for any help! >>>>> >>>> -- Resources: - http://web2py.com - http://web2py.com/book (Documentation) - http://github.com/web2py/web2py (Source code) - https://code.google.com/p/web2py/issues/list (Report Issues) --- You received this message because you are subscribed to the Google Groups "web2py-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to web2py+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
