>
> Hello,

I still think the "[Wiki]" should not be displayed if you are not logged 
in.   A wiki administrator would be logged in.   The general public don't 
need to see it.

The change is a little more complicated than I first suggested.  There is 
more happening after the "if self.auth.user: " code block at tools.py, line 
5088 that I think should be inside the auth.user check.  Shouldn't "Manage 
Pages" appear only to authorised users ?

By the way,  why have "if True: "  (line 5085)  .  Wouldn't that happen all 
the time ?

I can post this to the developer group if more appropriate.

Thanks.



On Saturday, October 27, 2012 9:01:42 AM UTC+13, Andrew W wrote:
>
> Looking at the change, it looks like a non logged in person can still see 
> "[Wiki]".  
> Could I suggest that the append statement comes inside the if 
> self.auth.user test:
>
>
if self.auth.user:
>     menu.append((current.T('[Wiki]'), None, None, submenu))
>
>
> On Friday, October 26, 2012 2:22:36 AM UTC+13, Massimo Di Pierro wrote:
>>
>> I agree. Changed the behavior in trunk.
>>
>> On Thursday, 25 October 2012 03:44:08 UTC-5, Andrew W wrote:
>>>
>>> the [wiki] menu option is good for the person maintaining the website, 
>>> but shouldn't be seen by others (at least those not logged in) .
>>> How do I hide it for unauthorised users ?
>>>
>>> Any update on when the book will contain auth.wiki information ?  I can 
>>> see plugin_wiki still there.
>>>
>>> Thanks
>>>
>>> Andrew W
>>>
>>

-- 



Reply via email to