Hi Philipp, On 15 December 2017 at 10:46, Philipp Zabel <[email protected]> wrote: > On Fri, 2017-12-15 at 09:46 +0000, Daniel Stone wrote: >> On 15 December 2017 at 09:25, Philipp Zabel <[email protected]> wrote: >> > Send format events instead of the modifier event, if the client binds on >> > a protocol version before version 3, skipping formats that only support >> > non-linear modifiers. >> >> Thanks for this! Could I please persuade you to take on one additional >> change though? >> >> Specifically, if has_dmabuf_import_modifiers is not supported, >> gl-renderer will return 0 for num_formats. In this case, it seems like >> we should send a conservative list: ARGB8888, XRGB8888, and maybe >> speculatively the YUV formats we have hardcoded conversions for >> (provided we have R8/RG8 support, cf. the patches from Arnaud). > > Should we modify gl_renderer_query_dmabuf_formats to return that list of > hardcoded formats if has_dmabuf_import_modifiers is not supported?
That was exactly what I had in mind. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
