On 5 December 2017 at 13:15, Daniel Stone <[email protected]> wrote:
> Hi Quentin, > I've added Ross and Fabien, who've been looking at this for Yocto. > > On 18 August 2017 at 10:30, Quentin Glidic > <[email protected]> wrote: > > --- a/wayland-scanner.m4 > > +++ b/wayland-scanner.m4 > > @@ -1,3 +1,5 @@ > > +#serial 2 > > I don't quite understand the significance of this. > autoconf macros can be versioned and this is how that is done. You don't see it much in practise because the one piece of autoconf which should respect the versions doesn't, but I approve of the intention! Fixing aclocal is on my long list of Things To Do, but this involves 1) autoconf 2) m4 so would mean more mental strength than I currently have. > > +# WL_PROG_WAYLAND_SCANNER() > > +AC_DEFUN([WL_PROG_WAYLAND_SCANNER], [ > > + AC_REQUIRE([AC_CANONICAL_BUILD]) > > + AC_REQUIRE([PKG_PROG_PKG_CONFIG]) > > + wl_cv_native_pkg_config= > > + AS_IF([test x${cross_compiling} = xyes], [ > > + wl_cv_native_pkg_config=${build}-pkg-config > > + AC_PATH_PROGS([wl_cv_native_pkg_config], [${build}-pkg-config]) > > Ah, no thanks. I would prefer to have this passed in as > $HOST_PKG_CONFIG (following the $HOST_CC precedent), falling back to > just plain 'pkg-config'. Guessing triplets is a bit too much like > magic, especially when you can be 'cross-compiling' to the same > triplet. > I'm not aware of a precedent for "this is the host pkgconfig" but I endorse HOST_PKG_CONFIG. Clear semantics and we could export it globally. It would be great if someone pushed that into pkg.m4... The rest looks good to me, so assuming we can test it in Yocto and it > works fine there, then it should be good to merge. > I'll definitely throw a v2 at our autobuilder cluster to see what happens. This builds gtk+, xserver-xorg and gstreamer with wayland support, which isn't everything but should be enough to find any gotchas. Ross
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
