On Tue, Sep 12, 2017 at 08:44:39PM +0200, Marco Martin wrote: > On Tue, Aug 22, 2017 at 6:07 PM, Marco Martin <[email protected]> wrote: > >> You'll need to create an "unstable v2" version, as this is a > >> non-backward compatible change. To do that, copy the XML file, changing > > > > attached a patch that adds the new v2 file, comments adressed > > ping? do i still need to do something on it?
Thanks for the ping, and sorry about the delay. The change to the protocol looks good to me, I only have three things to comment on: In general, it's a good idea to first copy (and maybe bump the numbers as you did), then in a follow up commit make the changes to the protocol. That would make it possible to review the actual changes, without having to compare manually. The other thing is that you also need to add the new file to Makefile.am, so that it'll be installed properly. And lastly, the patch submission procedure we use is sending patches to the E-mail list directly, not as attachments. You can do this for example with git-send-email. Jonas > > -- > Marco Martin _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
