GitHub user pablojan opened a pull request:
https://github.com/apache/incubator-wave/pull/21
Remove atmosphere as websocket's provider
Atmosphere has been use for last two years to provide a reliable transport
layer for the client-server communications. However, at this moment it seems
better to remove it because the library is not longer maintained and its
integration with wave's code base is quite complex. Another reason is the lack
of native clients of atmosphere for iOS and Android.
I think we can provide easily those features we liked in atmosphere:
- In real environments it is required to do keep alive pings through
websocket to avoid network issues.
- Long-polling alternative is becoming less necessary these days as long as
websocket is now widely adopted. Anyway, I think to implement long polling is
not so hard.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pablojan/incubator-wave websockets
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-wave/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit 61c1b21c71140ab5f3f885a452b56002d8cf6ebf
Author: wisebaldone <[email protected]>
Date: 2016-11-18T10:46:41Z
remove cc.kune dependency and replace with an initial default servlet.
commit 854d5606bf4003b72edd5445d3f05a4a2fc18b73
Author: wisebaldone <[email protected]>
Date: 2016-11-18T12:31:20Z
make gwt compilation incremental
commit 314ddcc70c3241d28db2bdcfc19e28ef979d25e0
Author: wisebaldone <[email protected]>
Date: 2016-11-18T14:34:53Z
remove testing dependencies from compile (move tests sources to test server)
commit 0294aafa02a1f4af5b7d95ac015999eb4cc6c5cb
Author: wisebaldone <[email protected]>
Date: 2016-11-18T16:52:24Z
fix tests which rely on the older version of mockito (requires changing
some matchers and some uses of all())
commit d851f2ce721a1ba3c7545e58eb013d8698fc7120
Author: wisebaldone <[email protected]>
Date: 2016-11-19T06:17:34Z
minor version changes
commit 25c7556332f3ca0adef43487016fdf6767891c58
Author: wisebaldone <[email protected]>
Date: 2016-11-20T05:29:44Z
Hot fix for editor misbehaving in chrome
commit 5ff642e0eafe690f43dc5369efe38d0c2b3ef5e4
Author: wisebaldone <[email protected]>
Date: 2016-11-20T07:25:44Z
Update gradle to latest version.
commit ad947ee975c30f3f99460c02e8f82d074da4fe1a
Author: wisebaldone <[email protected]>
Date: 2016-11-28T08:40:22Z
Rewritten FakeTimerServiceTest to use mockito instead of jmock.
commit 2d48da7802abc859ddbce17db7d0028cba6059f3
Author: wisebaldone <[email protected]>
Date: 2016-11-28T09:22:23Z
rewritten ControllerTest to use mockito instead of jmock
commit 8db12c97aa9637194eac72d0c2898cee9daa3661
Author: wisebaldone <[email protected]>
Date: 2016-11-28T10:16:25Z
changed IdempotentSchedulerTest to use mockito instead of jmock.
commit 8c8a690acf3d82110ea97922e07d9b68b3c99e59
Author: wisebaldone <[email protected]>
Date: 2016-11-28T15:41:19Z
Fixed Gwt tests and some tests are passing, others are not.
commit fd3265f25b25d6a75dfd279bd4b56bbcc06f3b7d
Author: wisebaldone <[email protected]>
Date: 2016-11-29T06:28:06Z
Minor edits to build logic.
commit bf3a90c00e84e65da6cab4943e845fc8b8dd4c0d
Author: wisebaldone <[email protected]>
Date: 2016-12-22T03:08:42Z
Merge branch 'master' into fix/dependendices-2016
commit 89f19a80a91d00db72ca2e9657583116428d12d9
Author: wisebaldone <[email protected]>
Date: 2016-12-22T03:12:01Z
Merge in Master
commit 7d80a8ba62d7d0613dfe3976fbd3e557c392c9f1
Author: wisebaldone <[email protected]>
Date: 2016-12-22T08:20:45Z
Changed build from UberJar to normal application dist.
Removed alot of startup scripts which dont have targets (they dont run
anything)
commit 4d5e92d1ecfaca0e7234919dc40476f139708226
Author: wisebaldone <[email protected]>
Date: 2016-12-22T08:57:43Z
Blacklisted the files which are generated by the proto compiler and
shouldnt be included in client.
commit 448cd1d60d58ebfe091793423a00304dc5a631c2
Author: wisebaldone <[email protected]>
Date: 2016-12-22T12:27:04Z
Fixed errors in the Gwt Tests, run ./gradlew testGwt
Paragraph tests an empty paragraph (doesnt have a min height) check the
rest of the tests to see why its been misbehaving.
commit fa86d0418abe923ff5d48e96a62ca10552b6f784
Author: Pablo Ojanguren <[email protected]>
Date: 2017-04-17T14:00:34Z
Removing atmosphere, revert to plain websockets
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
