----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45934/ -----------------------------------------------------------
Review request for wave, Andrew Kaplanov and Evan Hughes. Repository: wave Description ------- Adds (from wiab.pro) Shutdown Manager to allow for cleaner server shutdowns that close the server and resources. Diffs ----- wave/config/reference.conf 8142f9b wave/src/main/java/org/waveprotocol/box/server/ServerMain.java bfa3b92 wave/src/main/java/org/waveprotocol/box/server/executor/RequestScopeExecutor.java 40c2039 wave/src/main/java/org/waveprotocol/box/server/executor/ScheduledRequestScopeExecutor.java f841667 wave/src/main/java/org/waveprotocol/box/server/persistence/file/FileDeltaCollection.java 65683c4 wave/src/main/java/org/waveprotocol/box/server/shutdown/LifeCycle.java PRE-CREATION wave/src/main/java/org/waveprotocol/box/server/shutdown/ShutdownManager.java PRE-CREATION wave/src/main/java/org/waveprotocol/box/server/shutdown/ShutdownPriority.java PRE-CREATION wave/src/main/java/org/waveprotocol/box/server/shutdown/Shutdownable.java PRE-CREATION wave/src/main/java/org/waveprotocol/box/server/waveserver/WaveMap.java b2fa769 wave/src/test/java/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImplTest.java 1b5e5a1 wave/src/test/java/org/waveprotocol/box/server/waveserver/WaveMapTest.java 579dc7c wave/src/test/java/org/waveprotocol/box/server/waveserver/WaveServerTest.java 8291af3 Diff: https://reviews.apache.org/r/45934/diff/ Testing ------- - Checked that the servers starts - Application works - Tests pass Thanks, Yuri Zelikov