> On Feb. 19, 2016, 10:37 a.m., Yuri Zelikov wrote: > > wave/src/main/java/org/waveprotocol/box/server/ServerMain.java, line 264 > > <https://reviews.apache.org/r/43723/diff/1/?file=1254592#file1254592line264> > > > > Looks like it doesn't compile, needs to be CoreSettingsNames.
Maybe we should add pre-commit testing to jenkins. - Evan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43723/#review119827 ----------------------------------------------------------- On Feb. 18, 2016, 5:35 p.m., Pablo Ojanguren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43723/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 5:35 p.m.) > > > Review request for wave, Andrew Kaplanov, Vicente J. Ruiz Jurado, and Yuri > Zelikov. > > > Bugs: WAVE-436 > https://issues.apache.org/jira/browse/WAVE-436 > > > Repository: wave > > > Description > ------- > > In a public wavelet (those containing the @wavedomain user) a participant not > included in the participant's list can open the wavelet and see the content, > however she won't receive delta updates. > > This patch fixes the issue checking for implicit users to be updated when a > wavelet update is received in the server's client frontend. > > > Diffs > ----- > > wave/src/main/java/org/waveprotocol/box/server/ServerMain.java bfa3b92 > > wave/src/main/java/org/waveprotocol/box/server/frontend/ClientFrontendImpl.java > 3875b20 > wave/src/main/java/org/waveprotocol/box/server/frontend/WaveletInfo.java > 79950db > > wave/src/test/java/org/waveprotocol/box/server/frontend/ClientFrontendImplTest.java > 8a3f1d6 > > Diff: https://reviews.apache.org/r/43723/diff/ > > > Testing > ------- > > Updated unit tests. > Manual testing. > > > Thanks, > > Pablo Ojanguren > >
