> On Feb. 7, 2016, 1:54 nachm., Evan Hughes wrote: > > To build on what yuri said on the github. > > > > Having the example in the source files isnt end of the world as this is > > where the documentation is located. When the documentation is expanded apon > > and include in the docs repo then I agree but I dont see a problem with it > > being included here atm. > > > > > > In other news, do you mind squashing your commits so we only need to review > > one chunk ;).
I usually squash my commits for discrete & complete changes - in this case I wanted to give the opportunity for discussion of the lay of the land per change. I figure were I to implement LDAP-integration that'd only need to be one review in total, agreed. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43301/#review118177 ----------------------------------------------------------- On Feb. 7, 2016, 1:02 nachm., Andreas Kotes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43301/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2016, 1:02 nachm.) > > > Review request for wave. > > > Repository: wave > > > Description > ------- > > PST: add example code and some documentation > > > Diffs > ----- > > pst/README.md PRE-CREATION > pst/example/.gitignore PRE-CREATION > pst/example/beans.st PRE-CREATION > pst/example/example.proto PRE-CREATION > pst/example/example.st PRE-CREATION > > Diff: https://reviews.apache.org/r/43301/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Kotes > >
