----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42114/#review113948 -----------------------------------------------------------
Ship it! LGTM - Yuri Zelikov On Jan. 10, 2016, 1:44 p.m., Evan Hughes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42114/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 1:44 p.m.) > > > Review request for wave, Ali Lown and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > Reworked how the PST compiler is published and cleaned gradle files and > project layout. > > Fixes WAVE-435 > > > Diffs > ----- > > .gitignore dafa041 > build.gradle a96142d > pst/LICENSE PRE-CREATION > pst/build.gradle 530ee83 > pst/src/dist/LICENSE PRE-CREATION > pst/src/dist/NOTICE PRE-CREATION > pst/src/main/java/org/apache/wave/pst/Pst.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/PstCommandLine.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/PstException.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/PstFileDescriptor.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/PstMain.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/EnumValue.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/Field.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/Message.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/MessageProperties.java > PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/ProtoEnum.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/Type.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/model/Util.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/style/PstStyler.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/style/Styler.java PRE-CREATION > pst/src/main/java/org/apache/wave/pst/testing/RandomProtobufGenerator.java > PRE-CREATION > pst/src/main/java/org/waveprotocol/pst/Pst.java 98289e3 > pst/src/main/java/org/waveprotocol/pst/PstCommandLine.java dbc0223 > pst/src/main/java/org/waveprotocol/pst/PstException.java 388bd77 > pst/src/main/java/org/waveprotocol/pst/PstFileDescriptor.java cfc8b18 > pst/src/main/java/org/waveprotocol/pst/PstMain.java ea0693f > pst/src/main/java/org/waveprotocol/pst/model/EnumValue.java f3fd68c > pst/src/main/java/org/waveprotocol/pst/model/Field.java 97d3ac6 > pst/src/main/java/org/waveprotocol/pst/model/Message.java 6d945e7 > pst/src/main/java/org/waveprotocol/pst/model/MessageProperties.java 498f230 > pst/src/main/java/org/waveprotocol/pst/model/ProtoEnum.java ec33f4d > pst/src/main/java/org/waveprotocol/pst/model/Type.java 7b64abd > pst/src/main/java/org/waveprotocol/pst/model/Util.java 683bf7c > pst/src/main/java/org/waveprotocol/pst/style/PstStyler.java 9522120 > pst/src/main/java/org/waveprotocol/pst/style/Styler.java 910bc28 > pst/src/main/java/org/waveprotocol/pst/testing/RandomProtobufGenerator.java > 333b0e9 > pst/src/main/proto/google/protobuf/descriptor.proto PRE-CREATION > pst/src/main/proto/org/apache/wave/pst/protobuf/extensions.proto > PRE-CREATION > release/artifact-sign.sh 004d5f0 > scripts/vagrant/setup-fedora.sh c15a83f > scripts/vagrant/setup-ubuntu.sh 907576a > settings.gradle cf6215d > sonar-project.properties PRE-CREATION > wave-proto/build.gradle 5e8ba86 > wave-proto/src/main/proto/google/protobuf/descriptor.proto a753601 > wave-proto/src/main/proto/google/protobuf/descriptor.proto.v2.5 77eebe0 > wave-proto/src/main/proto/org/waveprotocol/box/attachment/attachment.proto > 78c95cc > > wave-proto/src/main/proto/org/waveprotocol/box/common/comms/waveclient-rpc.proto > 7b308a8 > wave-proto/src/main/proto/org/waveprotocol/box/profile/profiles.proto > 4370ee1 > wave-proto/src/main/proto/org/waveprotocol/box/search/search.proto 889ee05 > > wave-proto/src/main/proto/org/waveprotocol/box/server/persistence/protos/account-store.proto > cd52a51 > > wave-proto/src/main/proto/org/waveprotocol/box/server/persistence/protos/delta-store.proto > 09b1adb > wave-proto/src/main/proto/org/waveprotocol/box/server/rpc/rpc.proto 370cd74 > wave-proto/src/main/proto/org/waveprotocol/protobuf/build.xml 264c5c0 > wave-proto/src/main/proto/org/waveprotocol/protobuf/extensions.proto > 27f2901 > > wave-proto/src/main/proto/org/waveprotocol/wave/concurrencycontrol/clientserver.proto > 17c20a7 > wave-proto/src/main/proto/org/waveprotocol/wave/diff/build.xml 0b2ffc0 > wave-proto/src/main/proto/org/waveprotocol/wave/diff/diff.proto 1178a0b > > wave-proto/src/main/proto/org/waveprotocol/wave/federation/federation.protodevel > f5944ec > > wave-proto/src/main/proto/org/waveprotocol/wave/federation/federation_error.protodevel > f6fbcb7 > wave/build.gradle 9d57241 > wave/dependencies/compile/runtime/annotation-detector-3.0.0.jar 2e82c48 > wave/dependencies/compile/runtime/atmosphere-guice-0.8.3.jar 1546676 > wave/dependencies/compile/runtime/atmosphere-runtime-2.1.0.jar 005fa9b > wave/dependencies/compile/runtime/servlet-api-3.1.jar 6b14c3d > wave/dependencies/compile/runtime/whack.jar de2158e > wave/src/proto/proto/org/waveprotocol/box/attachment/attachment.proto > PRE-CREATION > wave/src/proto/proto/org/waveprotocol/box/common/comms/waveclient-rpc.proto > PRE-CREATION > wave/src/proto/proto/org/waveprotocol/box/profile/profiles.proto > PRE-CREATION > wave/src/proto/proto/org/waveprotocol/box/search/search.proto PRE-CREATION > > wave/src/proto/proto/org/waveprotocol/box/server/persistence/protos/account-store.proto > PRE-CREATION > > wave/src/proto/proto/org/waveprotocol/box/server/persistence/protos/delta-store.proto > PRE-CREATION > wave/src/proto/proto/org/waveprotocol/box/server/rpc/rpc.proto PRE-CREATION > > wave/src/proto/proto/org/waveprotocol/wave/concurrencycontrol/clientserver.proto > PRE-CREATION > wave/src/proto/proto/org/waveprotocol/wave/diff/build.xml PRE-CREATION > wave/src/proto/proto/org/waveprotocol/wave/diff/diff.proto PRE-CREATION > wave/src/proto/proto/org/waveprotocol/wave/federation/federation.protodevel > PRE-CREATION > > wave/src/proto/proto/org/waveprotocol/wave/federation/federation_error.protodevel > PRE-CREATION > > Diff: https://reviews.apache.org/r/42114/diff/ > > > Testing > ------- > > Can open the new tar.gz in ubuntu made from vagrant files and ran server on > windows. > > > Thanks, > > Evan Hughes > >
