> On Sept. 29, 2015, 9:09 a.m., Vicente J. Ruiz Jurado wrote: > > Thanks for the patch. You can check my email for a similar patch with asm > > 5: > > http://mail-archives.apache.org/mod_mbox/incubator-wave-dev/201412.mbox/%3c5483011f.1030...@ourproject.org%3E
Thanks for the link - but the patch linked from it doesn't seem to touch ASM or GWT 2.7.0 ? > On Sept. 29, 2015, 9:09 a.m., Vicente J. Ruiz Jurado wrote: > > .classpath, line 67 > > <https://reviews.apache.org/r/38831/diff/1/?file=1086285#file1086285line67> > > > > I think gwt 2.7 uses asm 5. You can search in google: "gwt 2.7" "asm 5". I chose asm 4 because of https://groups.google.com/forum/#!topic/google-web-toolkit/D1qoc8U0cGk but I have no strong feelings on which version should be used - I just picked the lowest one that worked to minimize the changes but 5.x seems more correct. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38831/#review100947 ----------------------------------------------------------- On Sept. 28, 2015, 11:37 p.m., Martin Letis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38831/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 11:37 p.m.) > > > Review request for wave and Ali Lown. > > > Repository: wave > > > Description > ------- > > Update GWT libraries in third_party from 2.6.1 to 2.7.0. > Also updates ASM from 3.3 to 4.0. > > > Diffs > ----- > > .classpath 88967fa > build.xml 893654a > > Diff: https://reviews.apache.org/r/38831/diff/ > > > Testing > ------- > > ant compile compile-gwt test dist > > > Thanks, > > Martin Letis > >
