Hi Ali, Thank you very much for the information.
Cheers, Roshan On Wed, Apr 15, 2015 at 5:46 AM, Ali Lown <a...@lown.me.uk> wrote: > Hi Roshan, > > Yes, generally there should be a ticket in JIRA for each 'thing' that > needs doing - some of the TODO's may already have a ticket - but I > doubt most of them do as some are quite old. > > We mention the process (in a _very_ brief form on the getting started > page[1]), but generally: > > 1) Create/assign/etc. a JIRA issue > 2) Work on a patch > 3) Create a single patch per logical item (might be one per issue - > but could be more for a complex problem) > 4) Submit this to review board, with assigned to the wave project, and > mentioning the JIRA issue number it relates to. > 5) Wait/pester us to get it reviewed > 6) Fix patch as suggested at review > 7) Push to git (if the person is a committer then they can do it > themselves, otherwise generally one of the reviewers will do it). > > Someone should put the above paragraph in an expanded form on the wiki > "contributing" page... > > Ali > > [1]: https://incubator.apache.org/wave/get-involved.html > > On 13 April 2015 at 15:40, Roshan Lakmal <roshan.2013...@iit.ac.lk> wrote: > > Hi, > > > > I have found lot of TODO entries in the wave src. > > If we completed a task. > > > > How can we submit the patch? > > Can you please tell me the procedure. > > > > Do we need to make a Jira issue and then submit the patch? > > There are some small TODO entries too. > > > > Cheers, > > > > Roshan >
