----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25230/#review51995 -----------------------------------------------------------
Thank you for patch. May be better to place "ReadableStringSet TEXT_FORMATTING_ANNOTATION_KEYS" into AnnotationConstants? It would be safe when annotation constant set is modified. src/org/waveprotocol/wave/client/editor/content/DiffHighlightingFilter.java <https://reviews.apache.org/r/25230/#comment90699> It may be unsafe. May be it is better to create common method to parse style annotation key? - Andrew Kaplanov On Сен. 1, 2014, 1:15 п.п., Denis Konovalchik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25230/ > ----------------------------------------------------------- > > (Updated Сен. 1, 2014, 1:15 п.п.) > > > Review request for wave, Andrew Kaplanov and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > At present moment the text marked as deleted within blip is displayed with > standard style, and any formatting of it made before is lost. This patch is > designed to display deleted text with the same formatting as it had before > deletion. > If it's necessary, instead of one span keeping deleted text with standard > style several spans are created, each of them has its own style attributes > (color, fontFamily, fontSize, fontStyle and fontWeight). Because attributes > "backgroundColor" (light red) and "textDecoration" (strike through) for any > deleted text are defined by css, they are not copied from the source text > formatting. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/editor/content/DiffHighlightingFilter.java > 30b4af2 > > Diff: https://reviews.apache.org/r/25230/diff/ > > > Testing > ------- > > Create blip with text and apply to it different formatting attributes (make > some parts of it italic, bold, some different font family, size and color). > Then delete this text by another user, and check that source formatting in > deleted area is the same as it was before deletion. > > > Thanks, > > Denis Konovalchik > >
