----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25021/#review51408 -----------------------------------------------------------
Ship it! LGTM. Committed as 9161196008317a67b71a64ca8286095b38633a69. Please close the review request. - Yuri Zelikov On Aug. 25, 2014, 11:42 a.m., Pablo Ojanguren wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25021/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 11:42 a.m.) > > > Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov. > > > Bugs: WAVE-416 > https://issues.apache.org/jira/browse/WAVE-416 > > > Repository: wave > > > Description > ------- > > > In an federated environment, when a remote delta is received in A from host > B, signature verification fails if B cert is a wildcard certificate. > > > Diffs > ----- > > src/org/waveprotocol/wave/crypto/WaveSignatureVerifier.java > 0b4238ec982484450d34fb54aeb0dce2c901289e > > Diff: https://reviews.apache.org/r/25021/diff/ > > > Testing > ------- > > In our federation test environment both servers are in the same domain, so > the problem arose: federation-1.p2pvalue.eu and federation-2.p2pvalue.eu > After server patch was applied the federation works good. > > > Thanks, > > Pablo Ojanguren > >
