----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25020/#review51394 -----------------------------------------------------------
Ship it! LGTM. - Ali Lown On Aug. 25, 2014, 11:25 a.m., Antonio Tenorio-Fornés wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25020/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 11:25 a.m.) > > > Review request for wave and Pablo Ojanguren. > > > Bugs: WAVE-269 > https://issues.apache.org/jira/browse/WAVE-269 > > > Repository: wave > > > Description > ------- > > Resolves bug WAVE-269. Gadgets are now inserted in the position of the cursor > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > 7abe368ba5119f42491f147d8a18e5f32ea9d3df > > Diff: https://reviews.apache.org/r/25020/diff/ > > > Testing > ------- > > - Write several lines text in a wave conversation. > - move cursor to an intermediate character of an intermediate line of the > text. > - The gadget is added at cursor position > > > Thanks, > > Antonio Tenorio-Fornés > >
