My concern with PRs, is that when it has lots of commits in, the resultant merge destroys the history.
I tried to git-bisect the other day, and kept having to skip through non-compiling commits that were doing partial work, that had been pulled in from a PR. Perhaps, PRs but only if the work has been pre-squashed for submission? Ali On 21 August 2014 23:38, Yuri Z <vega...@gmail.com> wrote: > Unless there's an Apache policy against that, I think we should prefer > GitHub pull requests. > > > On Fri, Aug 22, 2014 at 1:34 AM, Ali Lown <a...@lown.me.uk> wrote: > >> Yuri, >> >> I shall take a look at this tomorrow morning. >> >> (We should probably decide whether we are going to use PR as the >> review procedure instead of Review Board?) >> >> Ali >> >> On 21 August 2014 23:31, Yuri Z <vega...@gmail.com> wrote: >> > Hi >> > I made some changes to the original full text search with Solr patch by >> > Frank Ren and created a pull request on GitHub - >> > https://github.com/apache/incubator-wave/pull/4 >> > Please review. >> > Hopefully we will be able to do it fast so the full text search will be >> > included in the release. >>
