> On April 26, 2014, 3:36 p.m., Ali Lown wrote: > > LGTM.
commit 47cd2e99fd65c7278622d659b410b4941a8df91a - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20610/#review41557 ----------------------------------------------------------- On April 23, 2014, 4:21 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20610/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 4:21 p.m.) > > > Review request for wave, Ali Lown, Pablo Ojanguren, and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > Just removing the use of socketio-gwt. > > > Diffs > ----- > > .classpath ea8d06a > build.xml 8f1fc77 > src/org/waveprotocol/box/server/CoreSettings.java 0a6f3fd > src/org/waveprotocol/box/server/rpc/AbstractWaveSocketIOServlet.java > be90642 > src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java ca2f6b8 > src/org/waveprotocol/box/server/rpc/SocketIOServerChannel.java 2f8ec13 > src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java 0b68d71 > test/org/waveprotocol/box/server/rpc/RpcTest.java d86ddf8 > > Diff: https://reviews.apache.org/r/20610/diff/ > > > Testing > ------- > > gwt-compile and server basic tests > > > Thanks, > > Vicente J. Ruiz Jurado > >
