----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20207/#review40052 -----------------------------------------------------------
Ship it! LGTM. FYI: You need to put the bug id in as WAVE-411 for Reviewboard to link it up correctly... PS. For fixes of this size, it really wasn't worth a 'review', just commit them... - Ali Lown On April 10, 2014, 12:46 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20207/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 12:46 p.m.) > > > Review request for wave, Ali Lown, Pablo Ojanguren, and Yuri Zelikov. > > > Bugs: 411 > https://issues.apache.org/jira/browse/411 > > > Repository: wave > > > Description > ------- > > A fix for #411, so gadget transparent proxy works again with jetty 9. > > > Diffs > ----- > > src/org/waveprotocol/box/server/ServerMain.java 6887bcc > > Diff: https://reviews.apache.org/r/20207/diff/ > > > Testing > ------- > > For instance, > ant run-server > and try to open: > http://localhost:9898/gadgets/js/core:rpc.js > and not to get a 404. > > > Thanks, > > Vicente J. Ruiz Jurado > >
