Link.KEY and Link.PREFIX have always had the same value. Could you raise the link insertion failure as an actual bug in Jira?
On 13 March 2014 23:37, Vicente J. Ruiz Jurado <v...@ourproject.org> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16435/#review37135 > ----------------------------------------------------------- > > > Sorry, I'm late for these review, but Links where bad refactorized IMHO, and > now when you try to insert a link fails. > > Ali, see old Link.KEY and Link.PREFIX ... that seems to me that are renamed > both to LINK_PREFIX... > > - Vicente J. Ruiz Jurado > > > On Dec. 21, 2013, 3:57 p.m., Ali Lown wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/16435/ >> ----------------------------------------------------------- >> >> (Updated Dec. 21, 2013, 3:57 p.m.) >> >> >> Review request for wave, Joseph Gentle, Vicente J. Ruiz Jurado, and Yuri >> Zelikov. >> >> >> Repository: wave >> >> >> Description >> ------- >> >> Amazingly, all the useful constants to do with annotation keys were spread >> all over the codebase, (sometimes in multiple places). >> >> This puts them all in model/conversation (since defined in the conversation >> spec.), and then updates the rest of the codebase to use them. >> >> >> Diffs >> ----- >> >> src/org/waveprotocol/wave/client/doodad/link/Link.java 7b2b54a >> src/org/waveprotocol/wave/client/doodad/link/LinkAnnotationHandler.java >> 60bfe91 >> >> src/org/waveprotocol/wave/client/doodad/selection/SelectionAnnotationHandler.java >> 158876a >> >> src/org/waveprotocol/wave/client/doodad/suggestion/plugins/video/VideoLinkPlugin.java >> c0105d2 >> >> src/org/waveprotocol/wave/client/editor/content/misc/StyleAnnotationHandler.java >> 62f14f4 >> src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java >> 97e9064 >> src/org/waveprotocol/wave/model/conversation/AnnotationConstants.java >> PRE-CREATION >> src/org/waveprotocol/wave/model/operation/wave/WorthyChangeChecker.java >> d049c2e >> src/org/waveprotocol/wave/model/richtext/RichTextMutationBuilder.java >> 935c737 >> >> Diff: https://reviews.apache.org/r/16435/diff/ >> >> >> Testing >> ------- >> >> "ant clean get-third-party compile-gwt-dev dist-server" succeeds. >> >> >> Thanks, >> >> Ali Lown >> >> >
