----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18908/#review36532 -----------------------------------------------------------
Ship it! LGTM. This will result in increased filesize of the generated 'permutation' of the development JS. But the development JS is already large (due to the prettyness), so we don't really care about this. It may even be worth doing some benchmarks to see whether collapsing some of the permutations for the release version is worthwhile (with respect to the amount of time spent loading the resultant JS). - Ali Lown On March 7, 2014, 4:39 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18908/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 4:39 p.m.) > > > Review request for wave, Andrew Kaplanov, Ali Lown, and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > This decrease the number of permutations and the time of compilation in > development so this: > https://reviews.apache.org/r/17373 > is not necessary. > > More info: > https://code.google.com/p/google-web-toolkit/wiki/SoftPermutations > http://stackoverflow.com/questions/1011863/how-do-i-speed-up-the-gwt-compiler > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/WebClientDev.gwt.xml da32dd7 > > Diff: https://reviews.apache.org/r/18908/diff/ > > > Testing > ------- > > ant compile-gwt-dev dist-server run-server > > > Thanks, > > Vicente J. Ruiz Jurado > >
