----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17143/ -----------------------------------------------------------
Review request for wave and Yuri Zelikov. Repository: wave Description ------- - Appended session_cookie_max_age parameter to server.config. - Jetty does not allow to set infinite idle timeout to websocket session. It has default timeout 300000 ms. On attempt to assign 0, or -1 it says "IdleTimeout must be a postive value larger than 0". So, zero value, assigned to websocket_max_idle_time Wiab config variable, replaced to Integer.MAX_VALUE on call to Jetty. Diffs ----- build.xml 00d1f23 server-config.xml 16b4f68 server.config.example 309a0df src/org/waveprotocol/box/server/CoreSettings.java 5beaf65 src/org/waveprotocol/box/server/ServerModule.java 4dddaa1 src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 0809e9b Diff: https://reviews.apache.org/r/17143/diff/ Testing ------- Thanks, Andrew Kaplanov