For your information, you don't need to manually squash all your git
commits into a single commit, and then generate your single patch for
ReviewBoard.
Instead, you can directly convert all your commits into a single patch
(with no intermediary commit squash) using this:
$ git diff apache/trunk HEAD --binary
On 2013-12-18 01:03, Frank R. wrote:
Proxy Error
The proxy server received an invalid response from an upstream server.
The proxy server could not handle the request GET /r/16322/.
Reason: Error reading from remote server
Apache/2.2.20 (Ubuntu) Server at reviews.apache.org Port 443
On Wed, Dec 18, 2013 at 12:17 AM, Yuri Zelikov <vega...@gmail.com>
wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16322/
Thanks for doing this!
Just a few quick comments, please:
- remove commented lines
- remove or address todos/xxx's
- remove white spaces - they appear as red rectangles on the
ReviewBoard diff
- Yuri Zelikov
On December 17th, 2013, 4:08 p.m. UTC, Frank R. wrote:
Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri
Zelikov.
By Frank R..
*Updated Dec. 17, 2013, 4:08 p.m.*
*Repository: * wave
Description
For details (issues and commits):https://github.com/renfeng/wave
Testing
tests on search box
* in:inbox
* (empty) for all, including waves shared in the domain
* with:@
* (free texts)
tests on solr-bot
* single word
* phrase (quoted with double quotation marks)
* syntax applicable to search box
Diffs
- run-export.sh (d2cddb7)
- run-import.sh (45fff8a)
- server.config.example (19ba8b2)
- src/org/waveprotocol/box/server/SearchModule.java (2de0ef9)
- src/org/waveprotocol/box/server/ServerMain.java (b50454d)
-
src/org/waveprotocol/box/server/robots/agent/search/SolrRobot.java
(PRE-CREATION)
-
src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java
(2735940)
-
src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java
(PRE-CREATION)
-
src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java
(PRE-CREATION)
View Diff <https://reviews.apache.org/r/16322/diff/>
--
Regards/Saludos,
Bruno Gonzalez
http://www.stenyak.com | stenyak @ irc://irc.freenode.net
