----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12675/#review23400 -----------------------------------------------------------
Same here, using Yuri words, I think we better keep various implementations for now... Personally I see File Persistence only as a short term store and I think we should move to use other implementations in mid-term and long-term (something like the work Yuri did with Lucene, for instance). - Vicente J. Ruiz Jurado On July 17, 2013, 3:16 p.m., Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12675/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 3:16 p.m.) > > > Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri > Zelikov. > > > Repository: wave-git > > > Description > ------- > > This fully removes use of MongoDB as a backend for account, attachment and > certificate stores. > > This is part of an attempt to remove the excess/unused code from the > codebase. (A smaller code-base is much easier for people to work with). > Maintaining 2 distinct formats for the same data, and testing them both adds > a lot of work. > > Since mongodb persistence was never implemented for all (notable the lack of > delta persistence), it was impossible to store all wave data in a database. > As such, people (me) ended up using the file formats for all stores. > > There was no response to my email suggesting to get rid of it (Socket.IO was > saved by Vincente), so I have now put it here as a last call... > > > Diffs > ----- > > .classpath 725749b > build.xml 763bddc > server.config.example 19ba8b2 > src/org/waveprotocol/box/server/persistence/PersistenceModule.java a430570 > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbProvider.java > 6f5170f > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbStore.java > c6228b3 > src/org/waveprotocol/box/server/persistence/mongodb/mongodb.properties > 0f95fa4 > test/org/waveprotocol/box/server/persistence/mongodb/AccountStoreTest.java > df79f79 > > test/org/waveprotocol/box/server/persistence/mongodb/AttachmentStoreTest.java > 46dd70b > test/org/waveprotocol/box/server/persistence/mongodb/CertPathStoreTest.java > 62bcd74 > third_party/runtime/mongo-driver/LICENSE.txt 4a67574 > third_party/runtime/mongo-driver/README.google b5aaa70 > third_party/runtime/mongo-driver/mongo-2.1.jar > 0936004ad2dba281e67f244b127cbfe9d72fa426 > third_party/runtime/mongo-driver/mongo-java-driver-r2.1-0-src.zip > 41f4a34251228fcccf2ea3e11e1ea5d92ae73a22 > > Diff: https://reviews.apache.org/r/12675/diff/ > > > Testing > ------- > > Builds and passes test suite. > The composition of all 7 of these 'related' (but independent) patches is > verified to still work as a wave server. > > > Thanks, > > Ali Lown > >
