----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12684/ -----------------------------------------------------------
Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov. Repository: wave-git Description ------- Removes all references to Jackson. (There weren't any!) This library is completely redundant when GSON is used (which is the case for Wave). Josephg thinks it was probably left-over from some UTF-8 issues, which resulted in experimenting with different JSON libraries. PS. Well done for getting to the end of this series of reviews. If you left comments, even better! Diffs ----- .classpath 725749b build.xml 763bddc third_party/runtime/jackson/COPYING d645695 third_party/runtime/jackson/README.google 6f308e8 third_party/runtime/jackson/jackson-core-asl-1.5.2.jar 24107e68fedb0ea04291fa769cf992fc53608c60 Diff: https://reviews.apache.org/r/12684/diff/ Testing ------- Builds and passes test suite. The composition of all 7 of these 'related' (but independent) patches is verified to still work as a wave server. Thanks, Ali Lown
