El 15/07/13 19:12, Ali Lown escribió: > Deletion: > I feel that none of these libraries serve any purpose now, and should > be removed. > - codegen/SocketIO (superseded by Websockets, could-be-argued to keep > for legacy situations, but I don't feel it is worth the maintenance > effort) > - runtime/SocketIO ditto
When websocket it not available or is not working, the webclient uses socketio as a fallback (many times, because the client is under a proxy that blocks websocket connections, or because the browser is not up-to-date). You can see reconnectCommand in WaveWebSocketClient. So I think we should maintain socketio while we find a better alternative. For the release we can download it from our maven repository: http://archiva.comunes.org/#quicksearch~socketio Attached a patch of build.xml to get these dependencies (you can check that the MD5 are the same). BR, Vicente
diff --git a/build.xml b/build.xml index dc71d1a..2437737 100644 --- a/build.xml +++ b/build.xml @@ -256,10 +256,22 @@ <available file="third_party/test/emma/emma.jar" property="test.dependencies.2.present"/> <available file="third_party/test/junit/junit.jar" property="test.dependencies.3.present"/> <available file="third_party/test/junit/src.jar" property="test.dependencies.4.present"/> + <available file="third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT.jar" property="test.dependencies.5.present"/> + <available file="third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT-sources.jar" property="test.dependencies.6.present"/> + <available file="third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar" property="test.dependencies.7.present"/> + <available file="third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT-sources.jar" property="test.dependencies.8.present"/> + <available file="third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT.jar" property="test.dependencies.9.present"/> + <available file="third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT-sources.jar" property="test.dependencies.10.present"/> <fail message="${missing.dependencies.test} third_party/test/emma/emma_ant.jar" unless="test.dependencies.1.present"/> <fail message="${missing.dependencies.test} third_party/test/emma/emma.jar" unless="test.dependencies.2.present"/> <fail message="${missing.dependencies.test} third_party/test/junit/junit.jar" unless="test.dependencies.3.present"/> <fail message="${missing.dependencies.test} third_party/test/junit/src.jar" unless="test.dependencies.4.present"/> + <fail message="${missing.dependencies.test} third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT.jar" unless="test.dependencies.5.present"/> + <fail message="${missing.dependencies.test} third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT-sources.jar" unless="test.dependencies.6.present"/> + <fail message="${missing.dependencies.test} third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar" unless="test.dependencies.7.present"/> + <fail message="${missing.dependencies.test} third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT-sources.jar" unless="test.dependencies.8.present"/> + <fail message="${missing.dependencies.test} third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT.jar" unless="test.dependencies.9.present"/> + <fail message="${missing.dependencies.test} third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT-sources.jar" unless="test.dependencies.10.present"/> </target> <target name="compile-tests" depends="check-test-dependencies,compile" @@ -890,6 +902,18 @@ dest="third_party/test/junit/junit.jar"/> <get src="http://search.maven.org/remotecontent?filepath=junit/junit/4.10/junit-4.10-sources.jar" dest="third_party/test/junit/src.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-gwt/2012-10-21/socketio-gwt-2012-10-21.jar" + dest="third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-gwt-sources/2012-10-21/socketio-gwt-sources-2012-10-21.jar" + dest="third_party/codegen/socketio/socketio-gwt-0.1-SNAPSHOT-sources.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-core/2012-10-21/socketio-core-2012-10-21.jar" + dest="third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-core-sources/2012-10-21/socketio-core-sources-2012-10-21.jar" + dest="third_party/runtime/socketio/socketio-core-0.1-SNAPSHOT-sources.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-jetty/2012-10-21/socketio-jetty-2012-10-21.jar" + dest="third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT.jar"/> + <get src="http://archiva.comunes.org/repository/comunes-internal/com/glines/socketio/java/socketio-jetty-sources/2012-10-21/socketio-jetty-sources-2012-10-21.jar" + dest="third_party/runtime/socketio/socketio-jetty-0.1-SNAPSHOT-sources.jar"/> </target> <target name="doc" depends="stage" description="Builds the Java documentation for the mode, protocol, and Wave in a Box">