Actually, judging by the code, this does not really involve gravatar; it simply enables graphical rendering of the participants list (instead of simply textual), and does not necessarily force to use gravatar images (even though I believe that's the only possibility at the moment).
I'll submit a commit request for it. On Mon, Jun 10, 2013 at 6:20 AM, Zachary “Gamer_Z.” Yaro <zmy...@gmail.com>wrote: > If there are no negative comments, then you can probably go ahead with the > change. The only other potential problem I see is the fact that so many > profile pictures look similar, so there is no easy way to identify one > person. > > I recall Yuri's solution for setting profile pictures used Gravatar, but it > required some not-so-elegant shenanigans to get around the fact that > Gravatar requires an e-mail address and WIAB lacks an e-mail bridge (as we > have discussed elsewhere). > > > —Zachary “Gamer_Z.” Yaro > > > On 9 June 2013 17:58, Bruno Gonzalez (aka stenyak) <sten...@gmail.com > >wrote: > > > Just searched through the wave-dev mailing list archives. Gravatar was > > briefly discussed (for profile information storage, including avatar > image) > > at the end of year 2010, but there doesn't seem to be negative comments > > about it: > > > > > http://mail-archives.apache.org/mod_mbox/incubator-wave-dev/201012.mbox/%3caanlktingap1gyfwn8bu03xllto5rs3wknjjxgwgp4...@mail.gmail.com%3E > > > > > > On Fri, Jun 7, 2013 at 12:30 AM, Zachary “Gamer_Z.” Yaro > > <zmy...@gmail.com>wrote: > > > > > Have you looked through past mailing list discussions to see if the > > change > > > was previously rejected? I feel like I remember something about > Gravatar > > > being discussed in the past. > > > > > > —Zachary “Gamer_Z.” Yaro > > > On Jun 6, 2013 6:28 PM, "Bruno Gonzalez (aka stenyak)" < > > sten...@gmail.com> > > > wrote: > > > > > > > Shall it be committed to trunk then? > > > > > > > > > > > > On Thu, Jun 6, 2013 at 9:38 PM, Ali Lown <a...@lown.me.uk> wrote: > > > > > > > > > Upon inspection of the codebase history, I wonder if I am now > > > > > imagining the avatars being disabled, as I don't see a commit which > > > > > would have done so... > > > > > > > > > > Ali > > > > > > > > > > On 6 June 2013 20:00, Bruno Gonzalez (aka stenyak) < > > sten...@gmail.com> > > > > > wrote: > > > > > > There seems to exist a changeset that enables rendering of > avatars > > in > > > > the > > > > > > wave panel (top-right side), instead of the current text-only > list > > of > > > > > > participants. > > > > > > > > > > > > Ali mentioned gravatar used to be enabled for participant list, > but > > > at > > > > > some > > > > > > point it got disabled. > > > > > > > > > > > > Since the code is easy to integrate back (just 2 line changes), > I'm > > > > > > interested in knowing what the reasons were for disabling it in > the > > > > first > > > > > > place. > > > > > > > > > > > > I could understand not wanting to depend on third parties ( > > > > gravatar.com > > > > > ), > > > > > > but given that we are *already* using gravatar for the search > panel > > > > > > avatars, this is most probably not the reason. > > > > > > > > > > > > Does anyone remember anything about this? > > > > > > > > > > > > -- > > > > > > Saludos, > > > > > > Bruno González > > > > > > > > > > > > _______________________________________________ > > > > > > Jabber: stenyak AT gmail.com > > > > > > http://www.stenyak.com > > > > > > > > > > > > > > > > > > > > > -- > > > > Saludos, > > > > Bruno González > > > > > > > > _______________________________________________ > > > > Jabber: stenyak AT gmail.com > > > > http://www.stenyak.com > > > > > > > > > > > > > > > -- > > Saludos, > > Bruno González > > > > _______________________________________________ > > Jabber: stenyak AT gmail.com > > http://www.stenyak.com > > > -- Saludos, Bruno González _______________________________________________ Jabber: stenyak AT gmail.com http://www.stenyak.com
