-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11597/#review21289
-----------------------------------------------------------


Other than these issues, this seems like a sensible idea, so that the logging 
can be easily increased/decreased when it is necessary for diagnosing some 
problem with somebody's setup.


/wiab-logging.conf
<https://reviews.apache.org/r/11597/#comment44169>

    Trailing space.



/wiab-logging.conf
<https://reviews.apache.org/r/11597/#comment44170>

    Should ALL really be the default configuration? I don't think most people 
need this level of detail out-of-the-box.


- Ali Lown


On June 1, 2013, 5:39 p.m., Dave Ball wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11597/
> -----------------------------------------------------------
> 
> (Updated June 1, 2013, 5:39 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, Vicente J. Ruiz 
> Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> Improve default logging config.  Reduce the log output to the console, and 
> add logging to file.
> 
> 
> Diffs
> -----
> 
>   /run-server.sh 1487887 
>   /wiab-logging.conf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11597/diff/
> 
> 
> Testing
> -------
> 
> Ran up the server, made sure it logged as I expected...
> 
> 
> Thanks,
> 
> Dave Ball
> 
>

Reply via email to