----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11439/#review21072 -----------------------------------------------------------
Ship it! Trailing spaces on some lines (for some reason I can't comment inline) other than that LGTM! - Angus Turner On May 27, 2013, 10:05 p.m., Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11439/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 10:05 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Vicente J. Ruiz > Jurado. > > > Description > ------- > > This makes some more changes: > - Move other licenses from COPYING to LICENSE (and delete COPYING) > - Adds a KEYS to repo. (Add your own here too) > - Adds release-bin/release-src ant targets to handle automagically producing > unsigned tar.bz2/zip releases from the tree in one command. > > > Diffs > ----- > > /COPYING 1485998 > /KEYS PRE-CREATION > /LICENSE 1485998 > /build.properties 1485998 > /build.xml 1485998 > /run-server.sh 1485998 > > Diff: https://reviews.apache.org/r/11439/diff/ > > > Testing > ------- > > Running 'ant release' produces what I think it should. > I am not sure if I am missing any other files I should be including in an > artifact. > > > Thanks, > > Ali Lown > >
