----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7602/#review12474 -----------------------------------------------------------
src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java <https://reviews.apache.org/r/7602/#comment26542> This capitalization looks hideous. I don't see why this is a seperate function given it consists of 1 if statement, and is called in 1 place. Just inline it in reconnectCommand.execute src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java <https://reviews.apache.org/r/7602/#comment26543> Please move the magic number '2' to a clearly defined constant. Ali - Ali Lown On Oct. 15, 2012, 6:16 p.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7602/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 6:16 p.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > This patch fix WAVE-376, that is, detect that websocket it's not working and > try to use socket.io instead. > > This patch depends on https://reviews.apache.org/r/7600/ to work properly. > > > This addresses bug WAVE-376. > https://issues.apache.org/jira/browse/WAVE-376 > > > Diffs > ----- > > src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java 5645f5e > src/org/waveprotocol/box/webclient/client/WebClient.java 863ae6c > > Diff: https://reviews.apache.org/r/7602/diff/ > > > Testing > ------- > > How to test this: > - Configure your local WIAB under a http_proxy > - or: > 1) Configure your server websocket with a different name for websocket > address, for instance ws.localhost > 2) configure it in the /etc/hosts > 127.0.0.1 ws.localhost > 3) run the server > 4) test that all works ok using websocket > 5) remove the entry from /etc/hosts > 6) refresh your browser and check that websocket is not working and the > client use socketio instead. > > > Thanks, > > Vicente J. Ruiz Jurado > >
