-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6885/
-----------------------------------------------------------
(Updated Sept. 1, 2012, 3:33 p.m.)
Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
Changes
-------
Some initial patch following Yuri comment. Comments welcome.
Description
-------
This patch sets the same timeout to search queries that the search polling
interval, so if the server does not respond in time, the query is aborted.
This addresses bug WAVE-367.
https://issues.apache.org/jira/browse/WAVE-367
Diffs (updated)
-----
src/org/waveprotocol/box/webclient/search/JsoSearchBuilderImpl.java df37aa3
src/org/waveprotocol/box/webclient/search/RemoteSearchService.java 69374b5
src/org/waveprotocol/box/webclient/search/SearchBuilder.java c0f20fe
src/org/waveprotocol/box/webclient/search/SearchService.java 8d6c432
src/org/waveprotocol/box/webclient/search/SearchServiceImpl.java 12bb791
src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5240554
src/org/waveprotocol/box/webclient/search/testing/FakeSearchService.java
4d2af4b
Diff: https://reviews.apache.org/r/6885/diff/
Testing
-------
I was running the server with --debug and with a breakpoint in
SearchServlet.doGet so I see that client abort the query (with firebug) if the
server does not respond in time.
Thanks,
Vicente J. Ruiz Jurado
