> On 2012-01-23 20:15:39, Yuri Zelikov wrote: > > /src/org/waveprotocol/box/server/CoreSettings.java, line 57 > > <https://reviews.apache.org/r/3584/diff/2/?file=70249#file70249line57> > > > > I think the preferred practice is that boolean variables start with > > "is, has" etc.. > > Can we rename ENABLE_SSL to IS_SSL_ENABLED > > (also in other places)
Actually that would be the name of an access method (i.e. a getter). The variable name would probably be sslEnabled. The getter then becomes isSSLEnabled. However even saying that I am not sure this applies since we are talking about a string constant here. In terms of the config property we tend to be declarative / active. I.e. "disable_registration" rather than registration_disabled. The config name follows the existing pattern. Elsewhere, where we use enableSSL as a variable name. I agree that it should be sslEnabled. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3584/#review4537 ----------------------------------------------------------- On 2012-01-22 22:57:25, Ali Lown wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3584/ > ----------------------------------------------------------- > > (Updated 2012-01-22 22:57:25) > > > Review request for wave, Michael MacFadden and Yuri Zelikov. > > > Summary > ------- > > Adds SSL capabilities as: > > - Adds 3 new config options (globally enable ssl, keystore, keystore password) > - Changes to use the SSLSelectChannelConnector if needed > - Client-side websocket (wss/ws) detection based upon window.location.protocol > - Updates socket.io.js (separate from this since it couldn't be diff'd in > this conventional means being a binary blob) (I couldn't find a nicer way of > doing this detection, which is the same as the above js, to check > window.location.protocol then decide whether to set 'this.options.base.secure > = true' > As such, this has been attached to the 'Wave with HTTPS' mailing-list thread. > > > Diffs > ----- > > /server-config.xml 1234540 > /server.config.example 1234540 > /src/org/waveprotocol/box/server/CoreSettings.java 1234540 > > /src/org/waveprotocol/box/server/robots/operations/GravatarProfilesFetcher.java > 1234540 > /src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 1234540 > /src/org/waveprotocol/box/webclient/client/WebClient.java 1234540 > > Diff: https://reviews.apache.org/r/3584/diff > > > Testing > ------- > > _Correctly_ setting up the keystore is quite difficult if you want to use > existing certificates, but once setup: > - Tested with enableSsl = true -> works > - Tested with enableSsl = false -> works > > > Thanks, > > Ali > >
