FYI, I am traveling for the holidays so I am happy to take a look at this but it will not be before year's end, sorry!
- Lennard On Fri, Dec 23, 2011 at 18:29, Ali Lown <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3296/ > Review request for wave. > By Ali Lown. > > *Updated 2011-12-23 17:29:42.463299* > Changes > > Remove the change I made to build.xml (because I have one non-related test > case fail on my machine, so once the related tests pass I disable testing > (also speeds up recompiling)). > > Description > > Implements suggestions in WAVE-313: > - Adds a hideRegistration option to the server config file > - Removes the auth/registration route when this is the case > - Adds a RegistrationRobot to let the admin user always create new users > > Know limitations/features: > - Doesn't remove any 'register' links - server 404s when they are clicked. > - Manually created users don't get WelcomeBot'd > > Testing > > Compiled + run. Tried to access auth/register with hideRegistration=false and > hideRegistration=true. > Logged in as the admin user and tried to create new accounts with the > RegistrationRobot - then logged into new accounts to check valid. > > *Bugs: * WAVE-313 <https://issues.apache.org/jira/browse/WAVE-313> > Diffs (updated) > > - /server-config.xml (1213039) > - /server.config.example (1213039) > - /src/org/waveprotocol/box/server/CoreSettings.java (1213039) > - /src/org/waveprotocol/box/server/ServerMain.java (1213039) > - /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp > (1213039) > - /src/org/waveprotocol/box/server/robots/agent/RobotAgentUtil.java > (1213039) > - > /src/org/waveprotocol/box/server/robots/agent/registration/RegistrationRobot.java > (PRE-CREATION) > - /src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java > (1213039) > - /test/org/waveprotocol/box/server/rpc/UserRegistrationServletTest.java > (1213039) > > View Diff <https://reviews.apache.org/r/3296/diff/> >
