On Mon, Apr 25, 2011 at 2:52 AM, Pat Coleman <[email protected]> wrote: > Thomas - > It's awesome to see that the editor is coming in useful in other > applications! It was certainly designed for this sort of usage, so I hope it > comes in useful.
Thanks Pat for chiming in here! > In terms of the history you were talking about; there will likely be a few > things of GWT that it doesn't use the suggested version of > (like SafeHTML), a number of the GWT tools weren't around when the editor > code was first written but should use a similar API > to what's out there currently so in theory it could be migrated to the > proper libraries > (from memory, @Dan - can you think of anything missing in the GWT SafeHTML > that the editor needs?) There's no real equivalent to fromPlainText/appendPlainText, but fromSafeConstant/appendHtmlConstant were OK everywhere it was used: http://codereview.waveprotocol.org/581001 > In terms of Opera support; the tricky part is that to have a good editing > experience for even the current browser set we needed > workarounds for things like selection logic and event processing, stuff that > can't be covered by capability checking client-side (e.g. see > QuirksConstants). > We do have some level of defaults that was intended to be what an ideal > standards/w3c-compliant browser would behave, > so it could be possible to turn on Opera and give them the default editor > (or maybe replace it with the webkit/gecko/trident editor) but > my guess is doing that would result in some behavioural quirks that could > get annoying while editing and would require QuirksConstants workarounds. I don't have any issue with the fact the editor doesn't support Opera, just that it overrides/overwrites the user.agent property value-set and property-provider, and then forces the property value. Again, it was an easy fix: http://codereview.waveprotocol.org/574004 If you ever try to use the editor for an unsupported browser (provided it has its own user.agent value, i.e. not ie6 vs. ie7), compilation will just fail. You could use a rebind rule somewhere in your code to not make use of the editor in that case, and it should work (untested though). > Good luck with the integration! :) Thanks, but let's first understand how it all works! ;-) Is there some public documentation I would have missed? -- Thomas Broyer /tɔ.ma.bʁwa.je/
