Hi Andrew,
Hmmm, the fix was to get_changes.py to not download changes with -2
(before classification / report generation), so it would appear to be a
bug in the gerrit api. What change was it?
It worked for two of my changes which are set to -2 (33707 & 33727).
BTW, if you prefer to retain -2 changes in author's section, then I will
need to refactor my fix to elide the -2 changes during report generation.
Thanks,
-daw-
On 11/5/2022 5:34 AM, Andrew Yourtchenko wrote:
Hi Dave,
Very cool! I assume this change reflects only for the changes showing
in component maintainers’ lists, and not the authors ? (I saw one -2
change in my list in this report, which is the “correct” behavior imo,
so just making sure it is a feature and not a bug :)
--a
On 4 Nov 2022, at 16:13, Dave Wallace <dwallac...@gmail.com> wrote:
Folks,
I have enhanced the VPP Gerrit Report to not include gerrit changes
which are marked 'Code-review -2'. Today's report [0] reflects that
improvement.
Please let me know if you have any feedback on this report.
Thanks,
-daw-
[0] https://github.com/vpp-dev/vpp-gerrit-report
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22135): https://lists.fd.io/g/vpp-dev/message/22135
Mute This Topic: https://lists.fd.io/mt/94807675/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
