Hi Neale,

Comments inline...

On 10/17/22 10:46 PM, Neale Ranns wrote:

Hi Dave,

I fully support pluginification 😊

Is it fair though to say that if the remaining functions of vnet have a dependency on one of the modules below then that module is not a good candidate to move to a plugin?

[daw] Agreed.

If any function in the subtask list lands into this category I would recommend the following:
    1. Document the dependency in a comment of the subtask
    2. Mark the sub-task as 'Will Not Do'.

That way we have a list of dependencies that could potentially be refactored at a later time to allow the feature(s) to be moved to a plugin.

I thinking about the dependency between IPIP and TEIB. Some of the IPIP functionality (i.e. p2p tunnels) can be provided without TEIB but some cannot (i.e. p2mp tunnels).

  * Any thoughts on infrastructure to ease plugin on plugin
    dependencies. For example I seem to recall a system that used a
    ‘registry’ that the producer would populate and the consumer would
    invoke and that invocation would be sane in the absence of a producer.

[daw] Ole brought this up during our internal discussion with the reference to the same mechanism. I forgot to mention that I also added a Jira issue [2] to address this requirement.  Any features requiring cross-plugin dependency management should be marked as blocked by [2].  Let's use [2] to capture the requirements and assign a volunteer to lead the implementation.

 *


  * How do we [unit] test the various combinations of loaded plugins?
    Perhaps the default is not to load any plugins and the test-case
    specifies which set to load.


[daw] I agree that it would be best to default to not loading any plugins and have testcase specifications load the appropriate plugins as required.


Thanks,
-daw-

[2] https://jira.fd.io/browse/VPP-2060

/neale

*From: *vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> on behalf of Dave Wallace via lists.fd.io <dwallacelf=gmail....@lists.fd.io>
*Date: *Tuesday, 18 October 2022 at 08:57
*To: *vpp-dev <vpp-dev@lists.fd.io>
*Subject: *[vpp-dev] Move VNET features to plugins

Folks,

There has been a long standing chore to move VNET features to plugins
for which I've created a Jira ticket [0] to coordinate getting this work
done for VPP 23.02 release.

Can the maintainers of the VNET features [1] please sign up for the
associated subtask in [0] and complete the work before the 23.02 RC1
milestone (01/18/2023).  It would be great to get this done before the
end of 2022 to avoid a large influx of changes in early January.

Thanks in advance for your help!
-daw-

[0] https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjira.fd.io%2Fbrowse%2FVPP-2040&amp;data=05%7C01%7Cneale%40graphiant.com%7C888ed5dcf8744e783a0708dab08a892d%7C162101cdceb34e62ab2e3abc7aeede47%7C0%7C0%7C638016406459814597%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=qtN1mKiFVnGYzcW3lAsg7%2FSFLd5%2Bl8NICwMuqrG0m1M%3D&amp;reserved=0 <https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjira.fd.io%2Fbrowse%2FVPP-2040&amp;data=05%7C01%7Cneale%40graphiant.com%7C888ed5dcf8744e783a0708dab08a892d%7C162101cdceb34e62ab2e3abc7aeede47%7C0%7C0%7C638016406459814597%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=qtN1mKiFVnGYzcW3lAsg7%2FSFLd5%2Bl8NICwMuqrG0m1M%3D&amp;reserved=0>

[1] Current set of VNET features to be moved:
     BFD
     BIER
     CRYPTO
     GRE
     IPFIX-EXPORT
     IPIP
     IPSEC
     LAWFUL-INTERCEPT
     MPLS
     OSI
     POLICER
     PPP
     QOS
     SRMPLS
     SRV6
     TEIB
     TLS
     VXLAN
     VXLAN-GPE
     DEVICES:
         AF_PACKET
         PIPE
         TAP
         VIRTIO




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22048): https://lists.fd.io/g/vpp-dev/message/22048
Mute This Topic: https://lists.fd.io/mt/94396253/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to