Hi Andrew, cherry-pick for stable/2210: https://gerrit.fd.io/r/c/vpp/+/37413
Thanks Yulong Pei From: Andrew 👽 Yourtchenko <ayour...@gmail.com> Sent: Tuesday, October 18, 2022 1:58 PM To: Pei, Yulong <yulong....@intel.com> Cc: vpp-dev@lists.fd.io; Andrew Yourtchenko (ayourtch) <ayour...@cisco.com>; Ji, Kai <kai...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; Oginski, GabrielX <gabrielx.ogin...@intel.com> Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10 Hi Yulong, Cool, thanks! Then could you please make a cherry-pick into stable/2210 branch, and add me as a reviewer ? I will merge it. --a On 18 Oct 2022, at 03:51, Pei, Yulong <yulong....@intel.com<mailto:yulong....@intel.com>> wrote: Hi Andrew, I have been working on CSIT IPSec test for a long time, CSIT IPSec test use VPP python API for configuration, “SSWAN plugin https://gerrit.fd.io/r/c/vpp/+/36552” have no impact for CSIT IPSec test since it is only plugin for strongswan, and it do not build by defaut when building VPP, Also it located at vpp/extra dir, So it is no risk for VPP 22.10. Best Regards Yulong Pei From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> On Behalf Of Andrew Yourtchenko Sent: Friday, October 14, 2022 6:04 PM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10 Hi Kai, Having a second look at it - the plugin is offloading IPSec; So I would like some of the CSIT folks/IPSec maintainers to chime in with confirmation that they are comfortable with this… I think I might need to rescind the previous “no risk” assessment. --a On 14 Oct 2022, at 11:50, Ji, Kai <kai...@intel.com<mailto:kai...@intel.com>> wrote: Hi Andrew, Thank you for the reply, I’m agree with you, the https://gerrit.fd.io/r/c/vpp/+/36183 is way too big and risky for stable 22.10 now. In this case, can I kindly to ask you consider to merge VPP SSWAN plugin (https://gerrit.fd.io/r/c/vpp/+/36552) for 22.10 stable ? This patches only update the plugin and test script itself, and no dependences on vlibapi refactor and library fix. Regards Kai From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> On Behalf Of Andrew Yourtchenko Sent: Friday, October 14, 2022 9:57 AM To: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] VPP SSWAN plugin git cherry pick to stable 22.10 Kaj, *release manager hat on* we are past RC2 milestone - which means only critical fixes for CSIT tests go in. if the commit was just the plugin itself, in principle might be possible to entertain the idea, since a separate plugin is relatively low risk. But https://gerrit.fd.io/r/c/vpp/+/36183 is *far* too much risk to back port at this point in time, and is again not a fix per se. So unfortunately I will have to say “no” on this one. --a On 14 Oct 2022, at 10:43, Ji, Kai <kai...@intel.com<mailto:kai...@intel.com>> wrote: Hello We recently added fix plugin for vpp-sswan (https://gerrit.fd.io/r/c/vpp/+/36552) and I wonder if is it too late for this patch to be picked to stable 22.10 ? To make things more complicate, there is also a fix linked library patch for vpp-sswan https://gerrit.fd.io/r/c/vpp/+/37388 where need to be applied on top of vlibapi refactor (https://gerrit.fd.io/r/c/vpp/+/36183). Otherwise, the fix patch is no longer required if the vlibapi refactor is out of scope of stable 22.10. Regards Kai Ji --------------------------------------------------------------------- Intel Research and Development Ireland Ltd Co. Reg. #308263 Collinstown Industrial Park, Leixlip, County Kildare, Ireland
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22047): https://lists.fd.io/g/vpp-dev/message/22047 Mute This Topic: https://lists.fd.io/mt/94322720/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
