Hi folks, I have a question regarding "ip/ip6 table add" CLI command and the corresponding ip_table_add_del API call. There's a possibility to pass the "name" argument to the CLI command (even though it's omitted from its help): https://github.com/FDio/vpp/blob/0891b6aa449cca525b61d0cc23759b2efcd158dc/src/vnet/ip/lookup.c#L412 and also to the call https://github.com/FDio/vpp/blob/0891b6aa449cca525b61d0cc23759b2efcd158dc/src/vnet/ip/ip.api#L44 When "ip/ip6 table add" command is called repeatedly for the same table, fib_table_find_or_create_and_lock_i() is called each time. But this function doesn't replace the table name if it's already set: https://github.com/FDio/vpp/blob/0891b6aa449cca525b61d0cc23759b2efcd158dc/src/vnet/fib/fib_table.c#L1152-L1164 My question is: is this the intended behavior so that the table name (description) can't be changed once set? If it isn't, I'd gladly provide a patch. Or, should I add another API call (and perhaps a CLI command too) to rename tables? (Or maybe there is one already that I missed?)
Thanks, Ivan -- Ivan Shvedunov <ivan...@gmail.com> ;; My GPG fingerprint is: 2E61 0748 8E12 BB1A 5AB9 F7D0 613E C0F8 0BC5 2807
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21406): https://lists.fd.io/g/vpp-dev/message/21406 Mute This Topic: https://lists.fd.io/mt/91058465/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
