According to wiki [0], I am writing here to request Gerrit reviews on my recent contributions.
35697 [1] is the usual API endianness stuff. send_interface_tx_placement_details code contains a FIXME, but until that is done, my workaround is needed. 35838 [2] is also a common issue, a CLI command that consumes all the multiline input (and not just its own line), so it does not work when executed using "unix exec" part of startup.conf. The following is a piped command that can detect similarly defective CLI implementations: $ fgrep -rn UNFORMAT_END_OF_INPUT | fgrep while | fgrep cli | fgrep -v line_input Not sure if the detected code pattern can be legitimate in some circumstances. (If the "fgrep cli" is skipped, I see it also selects lines where the code is supposed to parse the whole multiline input.) If not, we can teach the checkstyle script to reject it (but that is probably a discussion for another thread). Vratko. [0] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#How_Do_I_Get_My_Patch_Reviewed_.3F [1] https://gerrit.fd.io/r/c/vpp/+/35697 [2] https://gerrit.fd.io/r/c/vpp/+/35838
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21196): https://lists.fd.io/g/vpp-dev/message/21196 Mute This Topic: https://lists.fd.io/mt/90240072/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
