Zach, Neale, Just a thought from the “make test” PoV:
If understand this email thread well, this change adds a behavior, relying on which can create security implications in case this new behavior gets broken - so you think you could add a few negative tests as well ? (I.e. that the packets indeed *are* dropped when they should be). If I am reading the tests right, they seem to be only verifying that the packets are passing… (apologies in advance if this is a misunderstanding) Thoughts ? --a > On 27 Jan 2022, at 09:51, Zachary Leaf <zachary.l...@arm.com> wrote: > > > Hi Neale, > > Please see https://gerrit.fd.io/r/c/vpp/+/34252 for the patch for this. Would > appreciate a review when you get the chance so Juraj can start adding the > CSIT tests required for the inbound side IPSec flow cache > (https://gerrit.fd.io/r/c/vpp/+/32903). > > Best, > > Zach > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20797): https://lists.fd.io/g/vpp-dev/message/20797 Mute This Topic: https://lists.fd.io/mt/84943480/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
