Hi Stanislav, Excellent, thank you!
/neale From: Stanislav Zaikin <zsta...@gmail.com> Date: Friday, 20 August 2021 at 16:38 To: Neale Ranns <ne...@graphiant.com> Cc: Artem Glazychev <artem.glazyc...@xored.com>, vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Adding new route via ipv6 link-local Hi Neale, If there are no volunteers, there's the patch: https://gerrit.fd.io/r/c/vpp/+/33558 On Fri, 20 Aug 2021 at 16:20, Neale Ranns <ne...@graphiant.com<mailto:ne...@graphiant.com>> wrote: Hi Artem, Stanislav, I agree graceful handling is needed, return false if there is no link local. If you enabled ip6 on the link first, this wouldn’t be a problem. The link will need to be ip6 enabled if you want something to reply. /neale From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> on behalf of Stanislav Zaikin via lists.fd.io<http://lists.fd.io> <zstaseg=gmail....@lists.fd.io<mailto:gmail....@lists.fd.io>> Date: Friday, 20 August 2021 at 16:10 To: Artem Glazychev <artem.glazyc...@xored.com<mailto:artem.glazyc...@xored.com>> Cc: vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] Adding new route via ipv6 link-local Hello Artem, Looks like we need (at least) to add a check for nullptr. DBGvpp# create tap tap0 DBGvpp# set interface state tap0 up DBGvpp# ip route add fa::1/120 via fe80::1 tap0 Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault. 0x00007ffff774ba90 in ip6_address_copy (dst=0x7fffaf487aa0, src=0x0) at /home/zstas/vpp/src/vnet/ip/ip6_packet.h:129 129 dst->as_u64[0] = src->as_u64[0]; (gdb) bt #0 0x00007ffff774ba90 in ip6_address_copy (dst=0x7fffaf487aa0, src=0x0) at /home/zstas/vpp/src/vnet/ip/ip6_packet.h:129 #1 0x00007ffff774b892 in fib_sas6_get (sw_if_index=1, dst=0x7fffb91b4e50, src=0x7fffaf487aa0) at /home/zstas/vpp/src/vnet/fib/fib_sas.c:105 On Fri, 20 Aug 2021 at 15:20, Artem Glazychev <artem.glazyc...@xored.com<mailto:artem.glazyc...@xored.com>> wrote: Hello, Found a crash: if we add the route via fe80:: after the interface upping - vpp crashes. For example: DBGvpp# create tap tap0 DBGvpp# set int state tap0 up DBGvpp# ip route add fa::1/120 via fe80::1 tap0 make: *** [Makefile:537: run] Aborted If we swap set ... up and ip route ... - no crashes. Could you please explain me if such a situation is possible at all? In any case, I believe that vpp should not crash. Thanks. -- Best regards Stanislav Zaikin -- Best regards Stanislav Zaikin
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19998): https://lists.fd.io/g/vpp-dev/message/19998 Mute This Topic: https://lists.fd.io/mt/85020362/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
