Hi Neale, inline
On Wed, Aug 11, 2021 at 6:36 PM Neale Ranns <ne...@graphiant.com> wrote: > Dear Ivan, > > > > That’s the best bug report I’ve seen in ages, so thank you! > You're welcome :) > I’ll take your patch as a starting point, but I’ll think I move the > responsibility for walking the incomplete adjacencies into the adj code; it > seems a little unfair for the ip-neighbour module to be responsible for > updating state it does not own. > > Can I add a ‘signed-off’ line with this email in the commit so you get the > deserved credit? > Sure, that would be nice, thanks! > > /neale > > > > > > *From: *vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> on behalf of Ivan > Shvedunov via lists.fd.io <ivan4th=gmail....@lists.fd.io> > *Date: *Wednesday, 11 August 2021 at 15:06 > *To: *vpp-dev <vpp-dev@lists.fd.io> > *Subject: *[vpp-dev] problem with updating incomplete adj nbr entries > upon MAC address change > > Hi, > > I've stumbled upon a problem in the neighbor adj code that handles > incomplete entries. These entries are pre-created under some circumstances > such as creation of a VXLAN tunnel and used to make Ethernet headers for > outbound ARP requests. Problem is, when the MAC address of the interface > changes, these entries are never updated. > > I've posted the detailed description and the patch as a GitHub gist [1]. > > Sadly, my fd.io Gerrit account is completely broken after what turned out > to be an unsuccessful login fix by the LF infra (IT-22698, IT-22257) so I > can't post the patch myself, sorry. > > > > [1] https://gist.github.com/ivan4th/d72d08be0fc53228cd4e7c6f19926c09 > > > > -- > > Ivan Shvedunov <ivan...@gmail.com> > ;; My GPG fingerprint is: 2E61 0748 8E12 BB1A 5AB9 F7D0 613E C0F8 0BC5 > 2807 > -- Ivan Shvedunov <ivan...@gmail.com> ;; My GPG fingerprint is: 2E61 0748 8E12 BB1A 5AB9 F7D0 613E C0F8 0BC5 2807
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19958): https://lists.fd.io/g/vpp-dev/message/19958 Mute This Topic: https://lists.fd.io/mt/84815615/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
