Hi VPP-developers, Please share your ideas about averaging window.
Thanks, Athilakshmi S On Mon, Jun 14, 2021 at 8:51 PM meera s via lists.fd.io <athi2812= gmail....@lists.fd.io> wrote: > Hi All, > > > > We are trying to implement the averaging window associated with QoS flows > in VPP - 21.06 > > We found that HQoS implementation in dpdk plugin, has tc_period > calculation, but deprecated from vpp. > > > > The following policer was configured > > configure policer name policer_avg type 1r2c cir 450 cb 5120000 rate kbps > conform-action mark-and-transmit CS4 exceed-action drop > > > > Following traces were added and observed with one ingress packet > > > > DBGvpp# At vnet_police_packet time -> 80082589943 > > packet_length = packet_length << policer->scale -> 56320 > > n_periods = time - policer->last_update_time -> 80082589943 > > policer->last_update_time = time -> 80082589943 > > current_tokens=policer->current_bucket + n_periods * > policer->cir_tokens_per_period -> 131418151536463 > > current_tokens = policer->current_limit -> 2621440000 > > extended_tokens = policer->extended_bucket + n_periods * > policer->cir_tokens_per_period -> 131415530096463 > > extended_tokens = policer->extended_limit -> 0 > > IF current_tokens >= packet_length 2621440000 -> 56320 > > policer->current_bucket = current_tokens - packet_length -> 2621383680 > > policer->extended_bucket = extended_tokens - packet_length -> 4294910976 > > > > From the above added traces, our understanding is > > > > "n_periods is the variable used for averaging window." Is our > understanding correct. > > Could you please let us know the usage of last_update_time in policer_t. > > > > Below code snippet is seen in HQoS, however deprecated in latest VPP. > > > > @param tc_period - enforcement period for rates (measured in milliseconds) > > > > define sw_interface_set_dpdk_hqos_subport { > > u32 client_index; > > u32 context; > > u32 sw_if_index; > > u32 subport; > > u32 tb_rate; > > u32 tb_size; > > u32 tc_rate[4]; > > u32 tc_period; > > }; > > > > Does tc_period computes the averaging window? > > If so, what is the equivalent to tc_period as in HQoS? > > > > Kindly let us know if Averaging window concept is handled in current code, > or share your view in handling it in VPP. > > > > > > Thanks and regards, > > Athilakshmi S > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#19571): https://lists.fd.io/g/vpp-dev/message/19571 Mute This Topic: https://lists.fd.io/mt/83532794/21656 Mute #vpp:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp Mute #vpp-dev:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp-dev Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-